On Jun 21, 2013, at 3:14 AM, Grant Likely <grant.lik...@secretlab.ca> wrote:

> On Fri, Jun 21, 2013 at 9:05 AM, Ryan Harkin <ryan.har...@linaro.org> wrote:
>> From: Leif Lindholm <leif.lindh...@linaro.org>
>> 
>> Currently, only ".efi" files are recognized as valid ARM UEFI
>> applications by BDS. This patch also makes ".EFI" files recognised.
>> 
>> Signed-off-by: Leif Lindholm <leif.lindh...@linaro.org>
>> ---
>> ArmPlatformPkg/Bds/BdsHelper.c |    3 +++
>> 1 file changed, 3 insertions(+)
>> 
>> diff --git a/ArmPlatformPkg/Bds/BdsHelper.c b/ArmPlatformPkg/Bds/BdsHelper.c
>> index fa3026c..d1889f4 100644
>> --- a/ArmPlatformPkg/Bds/BdsHelper.c
>> +++ b/ArmPlatformPkg/Bds/BdsHelper.c
>> @@ -205,6 +205,9 @@ HasFilePathEfiExtension (
>>   IN CHAR16* FilePath
>>   )
>> {
>> +  if (StrCmp (FilePath + (StrSize(FilePath)/sizeof(CHAR16)) - 5, L".EFI") 
>> == 0)
>> +    return 1;
>> +
> 
> Hmmm... we really should have an StrCaseCmp implementation in efi.
> 

It is implemented as a member in the EFI_UNICODE_COLLATION_PROTOCOL as defined 
by the UEFI spec. 
https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2/MdePkg/Include/Protocol/UnicodeCollation.h

It exists since case insensitive compares are required for the FAT filesystem 
driver. I think it is only currently used in the FAT driver so that is why we 
did not end up with a library to wrap the protocol. 

Thanks,

Andrew Fish


>>   return (StrCmp (FilePath + (StrSize(FilePath)/sizeof(CHAR16)) - 5, 
>> L".efi") == 0);
>> }
>> 
>> --
>> 1.7.9.5
>> 
>> 
>> ------------------------------------------------------------------------------
>> This SF.net email is sponsored by Windows:
>> 
>> Build for Windows Store.
>> 
>> http://p.sf.net/sfu/windows-dev2dev
>> _______________________________________________
>> edk2-devel mailing list
>> edk2-devel@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/edk2-devel
> 
> ------------------------------------------------------------------------------
> This SF.net email is sponsored by Windows:
> 
> Build for Windows Store.
> 
> http://p.sf.net/sfu/windows-dev2dev
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/edk2-devel


------------------------------------------------------------------------------
This SF.net email is sponsored by Windows:

Build for Windows Store.

http://p.sf.net/sfu/windows-dev2dev
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel

Reply via email to