Jaben,
This patch looks good to us and fixes all of the failing cases for us.
Thanks for the quick turnaround!
Eugene
From: Carsey, Jaben [mailto:jaben.car...@intel.com]
Sent: Friday, June 21, 2013 10:33 AM
To: Cohen, Eugene; edk2-devel@lists.sourceforge.net
Cc: Dellaquila, Katie; Carsey, Jaben
Subject: RE: ShellPkg: Recursive Delete Issues
Eugene,
Interesting. Can you tell me if this fixes it?
In an nutshell - the internal file listing mechanism does not account for file
system identifiers (i.e. "fs0:") in the file names before it tries to delete
them and it then fails to open the files that it finds in directories due to
this missing except when it is the current file system.
-Jaben
From: Cohen, Eugene [mailto:eug...@hp.com]
Sent: Thursday, June 20, 2013 3:14 PM
To: edk2-devel@lists.sourceforge.net<mailto:edk2-devel@lists.sourceforge.net>;
Carsey, Jaben
Cc: Dellaquila, Katie
Subject: ShellPkg: Recursive Delete Issues
Importance: High
Dear ShellPkg maintainer,
We are seeing an ASSERT with recursive deletion with the 'rm' shell command.
The issue seems to manifest when we try to delete a non-empty directory (and
hence the contents within it) when the command is executed from another drive
(or no current working directory at all).
Here are the cases that fail and succeed:
ASSERTS:
Shell> rm -q fs0:\folder (where 'folder' is a directory containing at least
one file)
ASSERT
d:\git\bios\edk2\ShellPkg\Library\UefiFileHandleLib\UefiFileHandleLib.c(281):
FileHandle != ((void *) 0)
Shell> fs1:
FS1:\> rm -q fs0:\folder (where 'folder' is a directory containing at least
one file)
ASSERT
d:\git\bios\edk2\ShellPkg\Library\UefiFileHandleLib\UefiFileHandleLib.c(281):
FileHandle != ((void *) 0)
SUCCEEDS:
Shell> rm -q fs0:\folder\foo.txt
Shell> rm -q fs0:\folder (where 'folder' is an empty directory)
Shell> fs1:
FS1:\> rm -q folder (where 'folder' is an empty directory OR a directory
containing at least one file)
FS1:\> rm -q folder\folder2 (where 'folder2' is an empty directory OR a
directory containing at least one file)
We have tried to debug the issue but so far have not yet comprehended the shell
internals enough to make sense of the failure.
Thanks,
Eugene
------------------------------------------------------------------------------
This SF.net email is sponsored by Windows:
Build for Windows Store.
http://p.sf.net/sfu/windows-dev2dev
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel
