I thought the change had no functionality impact to platforms. So I just choose OvmfPkgIa32X64.* to demonstrate the new DevicePathLib usage.
But I just realized the OVMF's SecureBootConfig driver was changed to use the new library so all the DSC/FDF has to be changed. I also fixed a OvmfIa32 build failure issue (it seems the OvmfIa32 is not well maintained for a long time. I fixed another build issue several weeks ago for the 32bit OVMF.) Please check the patch generated from the OvmfPkg directory. Change OVMF pure 32-bit and pure 64-bit platforms to use the new DevicePathLib. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni <[email protected]> -----Original Message----- From: Jordan Justen [mailto:[email protected]] Sent: Sunday, August 18, 2013 1:52 PM To: Ni, Ruiyu Cc: [email protected] Subject: RE: edk2 r14505 (Update all the code to consume the ConvertDe...) Ray, I have a few questions on this commit. Why didn't we update OvmfPkgX64.* and OvmfPkgIa32.*? What is the impact of not having these changes? Why didn't we separate out the OvmfPkg changes into a separate commit? Why didn't we get a chance to review this on edk2-devel? Thanks, -Jordan On Thu, Jul 25, 2013 at 8:14 PM, <[email protected]> wrote: > Revision: 14505 > http://sourceforge.net/p/edk2/code/14505 > Author: niruiyu > Date: 2013-07-26 03:14:08 +0000 (Fri, 26 Jul 2013) > Log Message: > ----------- > Update all the code to consume the ConvertDevicePathToText, > ConvertDevicePathNodeToText, ConvertTextToDevicePath and > ConvertTextToDeviceNode APIs in DevicePathLib. > > Signed-off-by: Ruiyu Ni <[email protected]> > Reviewed-by: Feng Tian <[email protected]> > Reviewed-by: Elvin Li <[email protected]> > Reviewed-by: Eric Dong <[email protected]> > Reviewed-by: Star Zeng <[email protected]> > Reviewed-by: Jaben Carsey <[email protected]> > Reviewed-by: Guo Dong <[email protected]> > > Modified Paths: > -------------- > trunk/edk2/IntelFrameworkModulePkg/Library/GenericBdsLib/DevicePath.c > trunk/edk2/IntelFrameworkModulePkg/Library/GenericBdsLib/GenericBdsLib.inf > trunk/edk2/IntelFrameworkModulePkg/Library/GenericBdsLib/InternalBdsLib.h > trunk/edk2/MdeModulePkg/Bus/Pci/PciBusDxe/PciBus.h > trunk/edk2/MdeModulePkg/Bus/Pci/PciBusDxe/PciBusDxe.inf > trunk/edk2/MdeModulePkg/Bus/Pci/PciBusDxe/PciLib.c > trunk/edk2/MdeModulePkg/Universal/DriverSampleDxe/DriverSample.c > trunk/edk2/MdeModulePkg/Universal/DriverSampleDxe/DriverSample.h > trunk/edk2/MdeModulePkg/Universal/DriverSampleDxe/DriverSampleDxe.inf > > trunk/edk2/MdeModulePkg/Universal/PlatformDriOverrideDxe/InternalPlatDriOverrideDxe.h > > trunk/edk2/MdeModulePkg/Universal/PlatformDriOverrideDxe/PlatDriOverrideDxe.c > > trunk/edk2/MdeModulePkg/Universal/PlatformDriOverrideDxe/PlatformDriOverrideDxe.inf > trunk/edk2/Nt32Pkg/Nt32Pkg.dsc > trunk/edk2/Nt32Pkg/Nt32Pkg.fdf > trunk/edk2/OvmfPkg/Library/PlatformBdsLib/BdsPlatform.c > trunk/edk2/OvmfPkg/Library/PlatformBdsLib/QemuBootOrder.c > trunk/edk2/OvmfPkg/OvmfPkgIa32X64.dsc > trunk/edk2/OvmfPkg/OvmfPkgIa32X64.fdf > trunk/edk2/OvmfPkg/SecureBootConfigDxe/SecureBootConfigDevicePath.c > trunk/edk2/OvmfPkg/SecureBootConfigDxe/SecureBootConfigDxe.inf > trunk/edk2/OvmfPkg/SecureBootConfigDxe/SecureBootConfigImpl.h
OvmfPkg.patch
Description: OvmfPkg.patch
------------------------------------------------------------------------------ Get 100% visibility into Java/.NET code with AppDynamics Lite! It's a free troubleshooting tool designed for production. Get down to code-level detail for bottlenecks, with <2% overhead. Download for free and get started troubleshooting in minutes. http://pubads.g.doubleclick.net/gampad/clk?id=48897031&iu=/4140/ostg.clktrk
_______________________________________________ edk2-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/edk2-devel
