On Sun, Aug 18, 2013 at 7:15 PM, Ni, Ruiyu <[email protected]> wrote: > I thought the change had no functionality impact to platforms. > So I just choose OvmfPkgIa32X64.* to demonstrate the new DevicePathLib usage.
I see. But, I usually work to keep all OvmfPkg dsc/fdf files in sync as much as possible. Can you separate out OvmfPkg changes and make sure we have the chance to review them on edk2-devel in the future? But, I don't understand why OVMF should be special in this. Why not give edk2-devel a chance to review all EDK II changes? > But I just realized the OVMF's SecureBootConfig driver was > changed to use the new library so all the DSC/FDF has to be changed. > I also fixed a OvmfIa32 build failure issue ( > it seems the OvmfIa32 is not well maintained for a long time. This is not quite true. I test IA32 almost as much as X64 with GCC. And I try to test VS2010 building for IA32 & X64 often too. Two porting areas I do have trouble with on OVMF are older VS and MS-ASL compatibility... > I fixed another build issue several weeks ago for the 32bit OVMF.) > > Please check the patch generated from the OvmfPkg directory. > > Change OVMF pure 32-bit and pure 64-bit platforms to use the new > DevicePathLib. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ruiyu Ni <[email protected]> Thanks for the contribution. I modified it to be 2 commits. (r14557-8) Can you send changes like these as separate patches in the future? I also left off a change to OvmfPkgX64.fdf which changed the FD/FV sizes. -Jordan > -----Original Message----- > From: Jordan Justen [mailto:[email protected]] > Sent: Sunday, August 18, 2013 1:52 PM > To: Ni, Ruiyu > Cc: [email protected] > Subject: RE: edk2 r14505 (Update all the code to consume the ConvertDe...) > > Ray, > > I have a few questions on this commit. > > Why didn't we update OvmfPkgX64.* and OvmfPkgIa32.*? What is the > impact of not having these changes? > > Why didn't we separate out the OvmfPkg changes into a separate commit? > > Why didn't we get a chance to review this on edk2-devel? > > Thanks, > > -Jordan ------------------------------------------------------------------------------ Get 100% visibility into Java/.NET code with AppDynamics Lite! It's a free troubleshooting tool designed for production. Get down to code-level detail for bottlenecks, with <2% overhead. Download for free and get started troubleshooting in minutes. http://pubads.g.doubleclick.net/gampad/clk?id=48897031&iu=/4140/ostg.clktrk _______________________________________________ edk2-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/edk2-devel
