I would like to revive discussion on this patch. It seems it has not been
accepted, perhaps we could have a comment here from the maintainer about
what is happening?
On 19 July 2013 20:11, Olivier Martin <[email protected]> wrote:
> Thanks Ting for the feedback,
> what about this new version (see attached patch)
>
> Best Regards,
> Olivier
> ________________________________________
> From: Ye, Ting [[email protected]]
> Sent: 30 January 2013 07:51
> To: [email protected]; Tian, Feng
> Subject: Re: [edk2] [PATCH] MdeModulePkg/MnpDxe: Checked returned value of
> Snp->GetStatus()
>
> Olivier,
>
> I don’t agree with this patch for the same reason. It is correct that upon
> a successful return of Snp->GetStatus(), Snp->Mode->MediaPresent will be
> updated to reflect current media status. But if this call meets error in
> some conditions, even though the media status is not updated to latest, we
> still need return SnpMode to the caller of MnpGetModeData since there are
> other useful parameters caller may be interested.
>
> Best Regards,
> Ting
>
> From: Olivier Martin [mailto:[email protected]]
> Sent: Friday, January 25, 2013 9:05 PM
> To: Tian, Feng
> Cc: [email protected]
> Subject: [edk2] [PATCH] MdeModulePkg/MnpDxe: Checked returned value of
> Snp->GetStatus()
>
> Dear MdeModulePkg maintainer,
> Please find the attached patch that checked the returned value of
> Snp->GetStatus() as explicitly said by the existing comment.
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Olivier Martin <[email protected]<mailto:
> [email protected]>>
>
> Best Regards,
> Olivier
>
> -- IMPORTANT NOTICE: The contents of this email and any attachments are
> confidential and may also be privileged. If you are not the intended
> recipient, please notify the sender immediately and do not disclose the
> contents to any other person, use it for any purpose, or store or copy the
> information in any medium. Thank you.
>
> -- IMPORTANT NOTICE: The contents of this email and any attachments are
> confidential and may also be privileged. If you are not the intended
> recipient, please notify the sender immediately and do not disclose the
> contents to any other person, use it for any purpose, or store or copy the
> information in any medium. Thank you.
>
>
> ------------------------------------------------------------------------------
> See everything from the browser to the database with AppDynamics
> Get end-to-end visibility with application monitoring from AppDynamics
> Isolate bottlenecks and diagnose root cause in seconds.
> Start your free trial of AppDynamics Pro today!
> http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk
> _______________________________________________
> edk2-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/edk2-devel
>
>
------------------------------------------------------------------------------
October Webinars: Code for Performance
Free Intel webinars can help you accelerate application performance.
Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from
the latest Intel processors and coprocessors. See abstracts and register >
http://pubads.g.doubleclick.net/gampad/clk?id=60134071&iu=/4140/ostg.clktrk
_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/edk2-devel
