Hi, Martin
Sorry for missing your mail such a long time. As Ting said, we keep the CopyMem
without checking the return status of Snp->GetStatus is to return other useful
parameters in case Snp->GetStatus() call meets error. With your updated patch
the Mnp->GetModeData() will return error code to caller instead of EFI_SUCCESS,
this usually makes the caller enter their error handling code and drop the
returned data. This behavior seems very weird and it may bring compatibility
problems to existing caller of MNP driver. So I think we'd better keep current
code logic.
Thanks
Fu, Siyuan
From: Olivier Martin [mailto:olivier.mar...@arm.com]
Sent: Tuesday, February 25, 2014 1:47 AM
To: 'Ryan Harkin'
Cc: edk2-devel@lists.sourceforge.net
Subject: Re: [edk2] [PATCH] MdeModulePkg/MnpDxe: Checked returned value of
Snp->GetStatus()
Ting, any feedback on this one?
From: Ryan Harkin [mailto:ryan.har...@linaro.org]
Sent: 09 October 2013 16:33
To: Olivier Martin
Cc: edk2-devel@lists.sourceforge.net<mailto:edk2-devel@lists.sourceforge.net>;
Tian, Feng
Subject: Re: [edk2] [PATCH] MdeModulePkg/MnpDxe: Checked returned value of
Snp->GetStatus()
I would like to revive discussion on this patch. It seems it has not been
accepted, perhaps we could have a comment here from the maintainer about what
is happening?
On 19 July 2013 20:11, Olivier Martin
<olivier.mar...@arm.com<mailto:olivier.mar...@arm.com>> wrote:
Thanks Ting for the feedback,
what about this new version (see attached patch)
Best Regards,
Olivier
________________________________________
From: Ye, Ting [ting...@intel.com<mailto:ting...@intel.com>]
Sent: 30 January 2013 07:51
To: edk2-devel@lists.sourceforge.net<mailto:edk2-devel@lists.sourceforge.net>;
Tian, Feng
Subject: Re: [edk2] [PATCH] MdeModulePkg/MnpDxe: Checked returned value of
Snp->GetStatus()
Olivier,
I don't agree with this patch for the same reason. It is correct that upon a
successful return of Snp->GetStatus(), Snp->Mode->MediaPresent will be updated
to reflect current media status. But if this call meets error in some
conditions, even though the media status is not updated to latest, we still
need return SnpMode to the caller of MnpGetModeData since there are other
useful parameters caller may be interested.
Best Regards,
Ting
From: Olivier Martin
[mailto:olivier.mar...@arm.com<mailto:olivier.mar...@arm.com>]
Sent: Friday, January 25, 2013 9:05 PM
To: Tian, Feng
Cc: edk2-devel@lists.sourceforge.net<mailto:edk2-devel@lists.sourceforge.net>
Subject: [edk2] [PATCH] MdeModulePkg/MnpDxe: Checked returned value of
Snp->GetStatus()
Dear MdeModulePkg maintainer,
Please find the attached patch that checked the returned value of
Snp->GetStatus() as explicitly said by the existing comment.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Olivier Martin
<olivier.mar...@arm.com<mailto:olivier.mar...@arm.com><mailto:olivier.mar...@arm.com<mailto:olivier.mar...@arm.com>>>
Best Regards,
Olivier
-- IMPORTANT NOTICE: The contents of this email and any attachments are
confidential and may also be privileged. If you are not the intended recipient,
please notify the sender immediately and do not disclose the contents to any
other person, use it for any purpose, or store or copy the information in any
medium. Thank you.
-- IMPORTANT NOTICE: The contents of this email and any attachments are
confidential and may also be privileged. If you are not the intended recipient,
please notify the sender immediately and do not disclose the contents to any
other person, use it for any purpose, or store or copy the information in any
medium. Thank you.
------------------------------------------------------------------------------
See everything from the browser to the database with AppDynamics
Get end-to-end visibility with application monitoring from AppDynamics
Isolate bottlenecks and diagnose root cause in seconds.
Start your free trial of AppDynamics Pro today!
http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.sourceforge.net<mailto:edk2-devel@lists.sourceforge.net>
https://lists.sourceforge.net/lists/listinfo/edk2-devel
------------------------------------------------------------------------------
Learn Graph Databases - Download FREE O'Reilly Book
"Graph Databases" is the definitive new guide to graph databases and their
applications. Written by three acclaimed leaders in the field,
this first edition is now available. Download your free book today!
http://p.sf.net/sfu/13534_NeoTech
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel
