Ting, any feedback on this one?
From: Ryan Harkin [mailto:ryan.har...@linaro.org]
Sent: 09 October 2013 16:33
To: Olivier Martin
Cc: edk2-devel@lists.sourceforge.net; Tian, Feng
Subject: Re: [edk2] [PATCH] MdeModulePkg/MnpDxe: Checked returned value of
Snp->GetStatus()
I would like to revive discussion on this patch. It seems it has not been
accepted, perhaps we could have a comment here from the maintainer about
what is happening?
On 19 July 2013 20:11, Olivier Martin <olivier.mar...@arm.com> wrote:
Thanks Ting for the feedback,
what about this new version (see attached patch)
Best Regards,
Olivier
________________________________________
From: Ye, Ting [ting...@intel.com]
Sent: 30 January 2013 07:51
To: edk2-devel@lists.sourceforge.net; Tian, Feng
Subject: Re: [edk2] [PATCH] MdeModulePkg/MnpDxe: Checked returned value of
Snp->GetStatus()
Olivier,
I don't agree with this patch for the same reason. It is correct that upon a
successful return of Snp->GetStatus(), Snp->Mode->MediaPresent will be
updated to reflect current media status. But if this call meets error in
some conditions, even though the media status is not updated to latest, we
still need return SnpMode to the caller of MnpGetModeData since there are
other useful parameters caller may be interested.
Best Regards,
Ting
From: Olivier Martin [mailto:olivier.mar...@arm.com]
Sent: Friday, January 25, 2013 9:05 PM
To: Tian, Feng
Cc: edk2-devel@lists.sourceforge.net
Subject: [edk2] [PATCH] MdeModulePkg/MnpDxe: Checked returned value of
Snp->GetStatus()
Dear MdeModulePkg maintainer,
Please find the attached patch that checked the returned value of
Snp->GetStatus() as explicitly said by the existing comment.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Olivier Martin
<olivier.mar...@arm.com<mailto:olivier.mar...@arm.com>>
Best Regards,
Olivier
-- IMPORTANT NOTICE: The contents of this email and any attachments are
confidential and may also be privileged. If you are not the intended
recipient, please notify the sender immediately and do not disclose the
contents to any other person, use it for any purpose, or store or copy the
information in any medium. Thank you.
-- IMPORTANT NOTICE: The contents of this email and any attachments are
confidential and may also be privileged. If you are not the intended
recipient, please notify the sender immediately and do not disclose the
contents to any other person, use it for any purpose, or store or copy the
information in any medium. Thank you.
----------------------------------------------------------------------------
--
See everything from the browser to the database with AppDynamics
Get end-to-end visibility with application monitoring from AppDynamics
Isolate bottlenecks and diagnose root cause in seconds.
Start your free trial of AppDynamics Pro today!
http://pubads.g.doubleclick.net/gampad/clk?id=48808831
<http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk
> &iu=/4140/ostg.clktrk
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel
------------------------------------------------------------------------------
Flow-based real-time traffic analytics software. Cisco certified tool.
Monitor traffic, SLAs, QoS, Medianet, WAAS etc. with NetFlow Analyzer
Customize your own dashboards, set traffic alerts and generate reports.
Network behavioral analysis & security monitoring. All-in-one tool.
http://pubads.g.doubleclick.net/gampad/clk?id=126839071&iu=/4140/ostg.clktrk
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel
