Hi Laszlo, The patch has been checked in at R14930. Thanks for your contribution.
Star -----Original Message----- From: Yao, Jiewen [mailto:jiewen....@intel.com] Sent: Tuesday, December 03, 2013 11:49 AM To: edk2-devel@lists.sourceforge.net Subject: Re: [edk2] [RFC 04/15] MdeModulePkg: SmmLockBox: remove wrong DepEx Hi Laszlo Thanks! This update seems good. And we need more test to see if there is any impact on real platforms, because of dependency change. Reviewed-by: Jiewen Yao <jiewen....@intel.com> -----Original Message----- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Monday, December 02, 2013 9:05 AM To: edk2-devel@lists.sourceforge.net Subject: [edk2] [RFC 04/15] MdeModulePkg: SmmLockBox: remove wrong DepEx The SmmLockBox driver in "MdeModulePkg/Universal/LockBox/SmmLockBox/SmmLockBox.inf" currently specifies a DepEx on EFI_SMM_SW_DISPATCH2_PROTOCOL. However, the driver doesn't use this protocol at all, either directly or indirectly. It calls SmiHandlerRegister() [MdeModulePkg/Core/PiSmmCore/Smi.c] to register SmmLockBoxHandler() (which serves LockBox requests). In turn, the SMM Core function SmiHandlerRegister() is also implemented without EFI_SMM_SW_DISPATCH2_PROTOCOL. The DepEx has been present since the initial commit of the SmmLockBox driver (SVN r12029); it is probably superfluous. Let's remove it. (Alternatively, we could extend OvmfPkg/EmuSmmDxe to fake this protocol, and return EFI_UNSUPPORTED when any member is called.) Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek <ler...@redhat.com> --- MdeModulePkg/Universal/LockBox/SmmLockBox/SmmLockBox.inf | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/MdeModulePkg/Universal/LockBox/SmmLockBox/SmmLockBox.inf b/MdeModulePkg/Universal/LockBox/SmmLockBox/SmmLockBox.inf index 529ca77..1804e8a 100644 --- a/MdeModulePkg/Universal/LockBox/SmmLockBox/SmmLockBox.inf +++ b/MdeModulePkg/Universal/LockBox/SmmLockBox/SmmLockBox.inf @@ -58,7 +58,6 @@ gEfiSmmReadyToLockProtocolGuid ## CONSUMED gEfiSmmAccess2ProtocolGuid ## CONSUMED gEfiLockBoxProtocolGuid ## PRODUCED [Depex] - gEfiSmmSwDispatch2ProtocolGuid - + TRUE -- 1.8.3.1 ------------------------------------------------------------------------------ Rapidly troubleshoot problems before they affect your business. Most IT organizations don't have a clear picture of how application performance affects their revenue. With AppDynamics, you get 100% visibility into your Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro! http://pubads.g.doubleclick.net/gampad/clk?id=84349351&iu=/4140/ostg.clktrk _______________________________________________ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel ------------------------------------------------------------------------------ Rapidly troubleshoot problems before they affect your business. Most IT organizations don't have a clear picture of how application performance affects their revenue. With AppDynamics, you get 100% visibility into your Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro! http://pubads.g.doubleclick.net/gampad/clk?id=84349351&iu=/4140/ostg.clktrk _______________________________________________ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel ------------------------------------------------------------------------------ Sponsored by Intel(R) XDK Develop, test and display web and hybrid apps with a single code base. Download it for free now! http://pubads.g.doubleclick.net/gampad/clk?id=111408631&iu=/4140/ostg.clktrk _______________________________________________ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel
