On Wed, May 14, 2014 at 10:02 AM, Gabriel L. Somlo <gso...@gmail.com> wrote:
> On Wed, May 14, 2014 at 09:24:03AM -0700, Jordan Justen wrote:
>> On Tue, May 13, 2014 at 3:13 PM, Gabriel L. Somlo <gso...@gmail.com> wrote:
>> > Contributed-under: TianoCore Contribution Agreement 1.0
>> > Signed-off-by: Gabriel Somlo <so...@cmu.edu>
>>
>> Can you sync this up with the address the patch is being sent from?
>
> I will try, and apologize in advance if I screw it up. Long, sad story,
> involving an unwelcome switch to Exchange of my primary email :)
Oh ... always fun. Somehow I managed to get exchange to not mangle my
patches at Intel, but I have no idea why it works. :)
(Actually, I'm not 100% sure they are not mangled, but no one is complaining :)
Anyway, maybe you can just reply to you patch posting from the other
address confirming the Signed-off-by?
>> > +/**
>> > + Frees the dynamically allocated portion of the extracted QEMU SMBIOS
>> > data
>> > +
>> > + @param[in] QemuTables Address of QEMU SMBIOS data from
>> > GetQemuSmbiosTables()
>> > +
>> > + It is the caller's responsibility to ensure QemuTables was allocated and
>> > + returned from GetQemuSmbiosTables().
>> > +
>> > + **/
>> > +VOID
>> > +FreeQemuSmbiosTables (
>> > + IN UINT8 *QemuTables
>> > + )
>> > +{
>> > + FreePool (QemuTables);
>> > +}
>>
>> I don't think we need this function.
>
> Unlike Xen, which just finds the SMBIOS blob in guest memory, I have
> to AllocatePool() a buffer for QemuTables in GetQemuSmbiosTables(),
> so there's a place to copy stuff from fw_cfg (via QemuFwCfgReadBytes()).
>
> If I don't free it afterwards, won't we end up with a memory leak ?
I meant just call FreePool directly.
-Jordan
------------------------------------------------------------------------------
"Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE
Instantly run your Selenium tests across 300+ browser/OS combos.
Get unparalleled scalability from the best Selenium testing platform available
Simple to use. Nothing to install. Get started now for free."
http://p.sf.net/sfu/SauceLabs
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel
