Jeff,

Can you do a contributed-under and signed off by for legal purposes...

-Jaben

From: Jeff Bobzin [mailto:[email protected]]
Sent: Thursday, July 24, 2014 7:58 AM
To: [email protected]
Subject: [edk2] Bug Report for UEFI Shell

Dear Shell Maintainers,

We would like you to check this -

In file ShellPkg\Library\UefiShellDebug1CommandsLib\Pci.h

Order of struct is wrong. Also structure name is misspelled but that is not as 
critical.

Original code below:

typedef struct {
  UINT8   PcieCapId;
  UINT8   NextCapPtr;
  UINT16  PcieCapReg;
  UINT32  PcieDeviceCap;
  UINT16  DeviceControl;
  UINT16  DeviceStatus;
  UINT32  LinkCap;
  UINT16  LinkControl;
  UINT16  LinkStatus;
  UINT32  SlotCap;
  UINT16  SlotControl;
  UINT16  SlotStatus;
  UINT16  RsvdP;
  UINT16  RootControl;
  UINT32  RootStatus;
} PCIE_CAP_STURCTURE;

Changed code below(in red)

typedef struct {
  UINT8   PcieCapId;
  UINT8   NextCapPtr;
  UINT16  PcieCapReg;
  UINT32  PcieDeviceCap;
  UINT16  DeviceControl;
  UINT16  DeviceStatus;
  UINT32  LinkCap;
  UINT16  LinkControl;
  UINT16  LinkStatus;
  UINT32  SlotCap;
  UINT16  SlotControl;
  UINT16  SlotStatus;
  UINT16  RootControl;
  UINT16  RsvdP;
  UINT32  RootStatus;
} PCIE_CAP_STURCTURE;

---Jeff Bobzin
Insyde Software
------------------------------------------------------------------------------
Want fast and easy access to all the code in your enterprise? Index and
search up to 200,000 lines of code with a free copy of Black Duck
Code Sight - the same software that powers the world's largest code
search on Ohloh, the Black Duck Open Hub! Try it now.
http://p.sf.net/sfu/bds
_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/edk2-devel

Reply via email to