Looks good.
I will have this in a combined patch with the changes required for the pci.c
file so the build doesn't break.
From: Jeff Bobzin [mailto:[email protected]]
Sent: Thursday, July 24, 2014 12:41 PM
To: [email protected]
Subject: Re: [edk2] Bug Report for UEFI Shell
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jeff Bobzin
([email protected]<mailto:[email protected]>)
Original code below:
typedef struct {
UINT8 PcieCapId;
UINT8 NextCapPtr;
UINT16 PcieCapReg;
UINT32 PcieDeviceCap;
UINT16 DeviceControl;
UINT16 DeviceStatus;
UINT32 LinkCap;
UINT16 LinkControl;
UINT16 LinkStatus;
UINT32 SlotCap;
UINT16 SlotControl;
UINT16 SlotStatus;
UINT16 RsvdP;
UINT16 RootControl;
UINT32 RootStatus;
} PCIE_CAP_STURCTURE;
Changed code below(in red)
typedef struct {
UINT8 PcieCapId;
UINT8 NextCapPtr;
UINT16 PcieCapReg;
UINT32 PcieDeviceCap;
UINT16 DeviceControl;
UINT16 DeviceStatus;
UINT32 LinkCap;
UINT16 LinkControl;
UINT16 LinkStatus;
UINT32 SlotCap;
UINT16 SlotControl;
UINT16 SlotStatus;
UINT16 RootControl;
UINT16 RsvdP;
UINT32 RootStatus;
} PCIE_CAP_STRUCTURE;
From: Carsey, Jaben [mailto:[email protected]]
Sent: Thursday, July 24, 2014 12:20 PM
To: [email protected]<mailto:[email protected]>
Subject: Re: [edk2] Bug Report for UEFI Shell
Jeff,
Can you do a contributed-under and signed off by for legal purposes...
-Jaben
From: Jeff Bobzin [mailto:[email protected]]
Sent: Thursday, July 24, 2014 7:58 AM
To: [email protected]<mailto:[email protected]>
Subject: [edk2] Bug Report for UEFI Shell
Dear Shell Maintainers,
We would like you to check this -
In file ShellPkg\Library\UefiShellDebug1CommandsLib\Pci.h
Order of struct is wrong. Also structure name is misspelled but that is not as
critical.
Original code below:
typedef struct {
UINT8 PcieCapId;
UINT8 NextCapPtr;
UINT16 PcieCapReg;
UINT32 PcieDeviceCap;
UINT16 DeviceControl;
UINT16 DeviceStatus;
UINT32 LinkCap;
UINT16 LinkControl;
UINT16 LinkStatus;
UINT32 SlotCap;
UINT16 SlotControl;
UINT16 SlotStatus;
UINT16 RsvdP;
UINT16 RootControl;
UINT32 RootStatus;
} PCIE_CAP_STURCTURE;
Changed code below(in red)
typedef struct {
UINT8 PcieCapId;
UINT8 NextCapPtr;
UINT16 PcieCapReg;
UINT32 PcieDeviceCap;
UINT16 DeviceControl;
UINT16 DeviceStatus;
UINT32 LinkCap;
UINT16 LinkControl;
UINT16 LinkStatus;
UINT32 SlotCap;
UINT16 SlotControl;
UINT16 SlotStatus;
UINT16 RootControl;
UINT16 RsvdP;
UINT32 RootStatus;
} PCIE_CAP_STURCTURE;
---Jeff Bobzin
Insyde Software
------------------------------------------------------------------------------
Infragistics Professional
Build stunning WinForms apps today!
Reboot your WinForms applications with our WinForms controls.
Build a bridge from your legacy apps to the future.
http://pubads.g.doubleclick.net/gampad/clk?id=153845071&iu=/4140/ostg.clktrk
_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/edk2-devel
