On Fri, 2014-07-25 at 16:16 +0200, Laszlo Ersek wrote: > On 07/25/14 04:40, Chen Fan wrote: > > Contributed-under: TianoCore Contribution Agreement 1.0 > > Signed-off-by: Chen Fan <[email protected]> > > --- > > MdePkg/Include/IndustryStandard/Pci22.h | 124 > > ++++++++++++++++---------------- > > MdePkg/Include/IndustryStandard/Pci23.h | 14 ++-- > > MdePkg/Include/IndustryStandard/Pci30.h | 2 +- > > 3 files changed, 70 insertions(+), 70 deletions(-) > > The different indentations are not misalignments. They reflect scoping. > For example: > > #define PCI_CLASS_DISPLAY 0x03 > #define PCI_CLASS_DISPLAY_VGA 0x00 > #define PCI_IF_VGA_VGA 0x00 > #define PCI_IF_VGA_8514 0x01 > #define PCI_CLASS_DISPLAY_XGA 0x01 > #define PCI_CLASS_DISPLAY_3D 0x02 > #define PCI_CLASS_DISPLAY_OTHER 0x80 > > Check out the IS_PCI_VGA() macro, and the > PCI_DEVICE_INDEPENDENT_REGION.ClassCode array. > > The macros / values are indented differently because they correspond to > different elements of the ClassCode array, and to different PCI concepts > (base class, subclass, programming interface). > > For example, "PCI_CLASS_DISPLAY_VGA" only makes sense (in ClassCode[1]) > after you've ascertained "PCI_CLASS_DISPLAY" (in ClassCode[2]). > Oh, Thanks for your explanation.
Chen > Thanks, > Laszlo > > > > ------------------------------------------------------------------------------ > Want fast and easy access to all the code in your enterprise? Index and > search up to 200,000 lines of code with a free copy of Black Duck > Code Sight - the same software that powers the world's largest code > search on Ohloh, the Black Duck Open Hub! Try it now. > http://p.sf.net/sfu/bds > _______________________________________________ > edk2-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/edk2-devel ------------------------------------------------------------------------------ Infragistics Professional Build stunning WinForms apps today! Reboot your WinForms applications with our WinForms controls. Build a bridge from your legacy apps to the future. http://pubads.g.doubleclick.net/gampad/clk?id=153845071&iu=/4140/ostg.clktrk _______________________________________________ edk2-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/edk2-devel
