On 06/08/14 19:10, Laszlo Ersek wrote: > Then, > > > @@ -567,3 +573,4 @@ > > !endif > > > > OvmfPkg/PlatformDxe/Platform.inf > > + IntelFrameworkModulePkg/Universal/DataHubDxe/DataHubDxe.inf > > No clue what this is good for. It seems to produce > gEfiDataHubProtocolGuid, which is consumed by... what?
I'll address the other points later. But this is actually a mistake. The DataHub protocol is not used by SataController. It's used to set the FSBFrequency for booting xnu kernels. I thought I removed all dependencies such as HFS in this patch but I missed this. > > Based on your recent patches, please be *much* more verbose in commit > messages. Both the pre-patch and the post-patch protocol dependency tree > should be described, with the relevant drivers identified. > > You can't avoid knowing all this information, because you fixed the > dependencies one by one. You added the one driver that you cared about, > and added the rest to resolve dependencies. Please capture that process > in the commit message with the tree I mentioned. > > Next week please ping Jordan too for a review. Will do, Thanks Reza ------------------------------------------------------------------------------ Infragistics Professional Build stunning WinForms apps today! Reboot your WinForms applications with our WinForms controls. Build a bridge from your legacy apps to the future. http://pubads.g.doubleclick.net/gampad/clk?id=153845071&iu=/4140/ostg.clktrk _______________________________________________ edk2-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/edk2-devel
