Hi, Sava & Reza Yes, I agree making this change should be acceptable for more device compatibilities.
Now we are discussing the place of break statement in new patch:). My idea is if D2H is received and the error bit of status register is NOT set, we should continue checking if all datum are received. If yes, then break. Please help me confirm if my though is right. Thanks Feng -----Original Message----- From: Reza Jelveh [mailto:[email protected]] Sent: Sunday, August 10, 2014 17:29 To: A. Sava; Alexander Graf; Tian, Feng Cc: [email protected] Subject: Re: [edk2] [PATCH 2/2] MdeModulePkg: Check D2H register status in AhciPioTransfer On 10/08/14 02:53, A. Sava wrote: > Hi Feng & Reza, > > In Qemu's case, it won't break out on a Setup FIS, because currently > for PIO commands, Qemu does not put at all a PIO Setup FIS at the end, > but only a D2H FIS. Perhaps other controllers with a similar problem > also have similar implementations. I'm inclined to think that this is not exclusive to Qemu, simply because OS drivers have no problem dealing with this behavior. Is there any reason that speaks against breaking out on D2H ? The current implementation breaks out anyway, but will unnecessarily fail to use the successfully read data. Meanwhile I'll see what I can do about the PIO Setup FIS in Qemu. ------------------------------------------------------------------------------ _______________________________________________ edk2-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/edk2-devel
