Jordan -- Yes, we want to disable anything non-spec (and in some cases, even those). Size sensitive applications are always trying to take out the pieces that they don't absolutely need. Adding a simple PCD allows us to make that choice without having to branch the code.
Tim -----Original Message----- From: Jordan Justen [mailto:jljus...@gmail.com] Sent: Thursday, August 21, 2014 2:43 PM To: Andrew J. Fish; edk2-devel@lists.sourceforge.net Subject: Re: [edk2] [PATCH RFC 0/4] UDF filesystem driver On Thu, Aug 21, 2014 at 1:37 PM, Paulo Alcantara <pca...@zytor.com> wrote: > On Thu, August 21, 2014 4:49 pm, Andrew Fish wrote: >> The spec is defining what is required to be implement. It does not >> limit what could be implemented. Thus you would probably want to add >> a PCD feature flag to turn on/off UDF support in the partition >> driver, and just default it to off. > > OK - figured it out. Thanks. > > Given that, I think I could start working on PartitionDxe to support > UDF and possibly use the "PCD feature flag" Andrew mentioned -- I > still need to take a look at how that works but sounds good to me the > ability to turn on/off it. > > How about that guys? I don't see a reason to want to disable it. It will just cause an extra DiskIo to be produced for the UDF "partition". Do you think a PCD is really needed Andrew? -Jordan ------------------------------------------------------------------------------ Slashdot TV. Video for Nerds. Stuff that matters. http://tv.slashdot.org/ _______________________________________________ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel ------------------------------------------------------------------------------ Slashdot TV. Video for Nerds. Stuff that matters. http://tv.slashdot.org/ _______________________________________________ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel
