On 08/29/14 09:53, Ard Biesheuvel wrote: > On 29 August 2014 04:20, Laszlo Ersek <[email protected]> wrote:
>> III. >> >> Notes about testing: >> >> - this series doesn't apply on current edk2 master; please rebase it for >> v6. For testing, I applied it on git commit 421ccda3. >> > > Yes, that is the branch point I used after rebasing the v1. > Unfortunately, I am now seeing this > > build.py... > /home/ard/build/uefi-next/ArmPlatformPkg/ArmVirtualizationPkg/ArmVirtualizationQemu.dsc(...): > error 1001: Module type [SEC] is not supported by library instance > [/home/ard/build/uefi-next/MdePkg/Library/UefiBootServicesTableLib/UefiBootServicesTableLib.inf] > consumed by > [/home/ard/build/uefi-next/ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf] > > which i am trying to bisect now. Hm. Interesting. UefiBootServicesTableLib is *genuinely* unusable in a SEC module. I can think of two possibilities: (a) The bug was always there in the series, and BuildTools didn't notice only because UefiBootServicesTableLib didn't communicate its module type restriction. Note that even this way UefiBootServicesTableLib could have never worked in a SEC module. In other words, you may have a dependency on it somewhere, in an INF file, but you never actually use anything from that library. So it should be a matter of dropping the reference in some INF file's [LibraryClasses] section. (b) Some generic ARM module that your series depends on (in a SEC module) introduced a new dependency on UefiBootServicesTableLib in the interim. Hence your code now inherits this dependency for the SEC module. This is invalid of course. In this case you might have to fork the generic ARM module for the virt Pkg. I wonder if adding --report-file=build.report to your build command line could help you see the library dependency chains. Thanks Laszlo ------------------------------------------------------------------------------ Slashdot TV. Video for Nerds. Stuff that matters. http://tv.slashdot.org/ _______________________________________________ edk2-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/edk2-devel
