On Thu, Sep 11, 2014 at 12:36 AM, Fan, Jeff <[email protected]> wrote:
> I added my comments in [Jeff].
> -----Original Message-----
> From: Jordan Justen [mailto:[email protected]]
> Sent: Thursday, September 11, 2014 3:21 PM
> To: Fan, Jeff
> Cc: Chen Fan; [email protected]
> Subject: Re: [RFC v2 00/15] Introduce Mp Service protocol to
> UefiCpuPkg
>
> On Wed, Sep 10, 2014 at 11:56 PM, Fan, Jeff <[email protected]> wrote:
>> There is no .ASM implementation, we need to check-in code in
>> UefiCpuPkg to support both MSFT and GCC. Maybe .nasm is good start to
>> support both at one time for such new assembly code. :-)
>
> The startup routine is in ApStartup.c, so it should work with all
> toolchains. (The NASM source helped construct the ApStartup.c code.)
>
> I told Chen I would provide the MpAsm.asm files. I haven't done that yet...
> [Jeff] I mean MpAsm.asm files. Why not to write MpAsm.nasm files only?
Oh, I see what you mean. I agree with your point.
One issue is that we don't yet require NASM to be installed for Visual Studio
toolchains, but we want CpuDxe to support those toolchains.
Or, can we start to require NASM for VS toolchains to build UefiCpuPkg/CpuDxe?
We updated the VS toolchains for NASM, but I'm not sure how much testing that
got.
Maybe instead of .S, we should provide .nasm source for this when building on
GCC toolchains, since NASM is already a requirement for MdePkg.
Would you be able to help test .nasm with a Visual Studio toolchain if I
convert that code to .nasm?
[Jeff] It makes sense to add .ASM instead of .nasm for MSFT toolchain for this
patch.
I could test .nasm for MSFT toolchain.
-Jordan
------------------------------------------------------------------------------
Want excitement?
Manually upgrade your production database.
When you want reliability, choose Perforce
Perforce version control. Predictably reliable.
http://pubads.g.doubleclick.net/gampad/clk?id=157508191&iu=/4140/ostg.clktrk
_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/edk2-devel
