On 11/26/14 02:39, Tian, Feng wrote: > Hi, Laszlo > > Shall we cleanup all of APIs in UefiScsiLib?
I did notice that they have similar LUN encodings but I assumed those were okay. However... > Looks like TEST_UNIT_READY, according to SPC-4, 6.37, the entire Cdb[1] byte is Reserved, > INQUIRY, 6.4.1 says Cdb[1] bits [7:2] are Reserved, > MODE_SENSE, 6.11.1 MODE SENSE(6) defines Cdb[1] bits [7:4] as Reserved, 6.12 MODE SENSE(10) defines Cdb[1] bits [7:5] as Reserved, > REQUEST_SENSE 6.29 says Cdb[1] bits [7:1] are Reserved, > and READ_CAPACITY cmds all have same issue. SBC-3 5.16 READ CAPACITY (10) Reserves Cdb[1] bits [7:1]. Similarly 5.17 READ CAPACITY (16) says Cdb[1] bits [7:5] are Reserved. Here's what I propose: let's keep my *v3* patch (ie. not this v2 one) as-is, and I will send a followup patch (as PATCH v3 2/1) that covers the above. I think it makes some sense to keep the patches separate, as the first one fixes an actual mis-mapping, while the second one will fix incorrect population of Reserved fields. Thanks! Laszlo ------------------------------------------------------------------------------ Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server from Actuate! Instantly Supercharge Your Business Reports and Dashboards with Interactivity, Sharing, Native Excel Exports, App Integration & more Get technology previously reserved for billion-dollar corporations, FREE http://pubads.g.doubleclick.net/gampad/clk?id=157005751&iu=/4140/ostg.clktrk _______________________________________________ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel
