Tim,
I see your point, and it does make sense to keep the Shell as independent as
possible .On the other hand, commands like DH are very useful for debugging,
and we should not artificially limit their capabilities because of EDK2 source
structure.
I vote for your second proposal: duplicate the GUID definitions in the
ShellPkg.dec
Thanks,
--Samer
From: Tim Lewis [mailto:tim.le...@insyde.com]
Sent: Tuesday, November 25, 2014 6:33 PM
To: edk2-devel@lists.sourceforge.net
Subject: Re: [edk2] [PATCH] ShellPkg: Update DH for AdapterInfoProtocol
Jaben -
Consider an ARM source delivery. Do we really a package full of Intel-isms
delivered? They never use those protocols and likely never will.
We can rebuild the shell entirely by itself, like a UEFI app, and it currently
depends only on MdePkg and MdeModulePkg.
My first choice would be just to leave them out. My next choice would be to
duplicate any extraneous values in the ShellPkg.dec
Tim
From: Carsey, Jaben [mailto:jaben.car...@intel.com]
Sent: Tuesday, November 25, 2014 4:18 PM
To: edk2-devel@lists.sourceforge.net<mailto:edk2-devel@lists.sourceforge.net>
Subject: Re: [edk2] [PATCH] ShellPkg: Update DH for AdapterInfoProtocol
I think that knowing the name of a produced protocol is pretty useful. The
only alternative I thought about is putting copies of the GUIDs in the shell.
What would you propose?
-Jaben
From: Tim Lewis [mailto:tim.le...@insyde.com]
Sent: Tuesday, November 25, 2014 4:14 PM
To: edk2-devel@lists.sourceforge.net<mailto:edk2-devel@lists.sourceforge.net>
Subject: Re: [edk2] [PATCH] ShellPkg: Update DH for AdapterInfoProtocol
Jaben, Samer -
Do we really want to make the shell dependent on the IntelFrameworkModulePkg?
Tim
From: Carsey, Jaben [mailto:jaben.car...@intel.com]
Sent: Tuesday, November 25, 2014 2:42 PM
To: edk2-devel@lists.sourceforge.net<mailto:edk2-devel@lists.sourceforge.net>
Subject: Re: [edk2] [PATCH] ShellPkg: Update DH for AdapterInfoProtocol
Reviewed-by: Jaben Carsey
<jaben.car...@intel.com<mailto:jaben.car...@intel.com>>
Commit 16445
p.s. I had to rework the commit message a little to get it past the "guard" or
whatever controls commit messages.
From: El-Haj-Mahmoud, Samer [mailto:samer.el-haj-mahm...@hp.com]
Sent: Tuesday, November 25, 2014 2:08 PM
To: edk2-devel@lists.sourceforge.net<mailto:edk2-devel@lists.sourceforge.net>
Subject: [edk2] [PATCH] ShellPkg: Update DH for AdapterInfoProtocol
Jaben,
Can you please review this and submit it?
Update Shell DH command to display gEfiAdapterInformationProtocolGuid and decode
information blocks defined in the UEFI 2.4 specification.
Also added GUIDs for gEfiIsaIoProtocolGuid and gEfiIsaAcpiProtocolGuid
protocols.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Samer El-Haj-Mahmoud el...@hp.com<mailto:el...@hp.com>
Thanks,
Samer El-Haj-Mahmoud
System Firmware Architect
HP Servers
el...@hp.com<mailto:el...@hp.com>
T +1.281.514.5973
C +1.512.659.1523
Hewlett-Packard Company
hp.com/go/proliant/uefi<http://hp.com/go/proliant/uefi>
[Description: Description: C:\Users\elhajmah\HpLogo.png]
------------------------------------------------------------------------------
Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server
from Actuate! Instantly Supercharge Your Business Reports and Dashboards
with Interactivity, Sharing, Native Excel Exports, App Integration & more
Get technology previously reserved for billion-dollar corporations, FREE
http://pubads.g.doubleclick.net/gampad/clk?id=157005751&iu=/4140/ostg.clktrk
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel
