That seems OK
From: Carsey, Jaben [mailto:[email protected]]
Sent: Tuesday, December 02, 2014 12:53 PM
To: [email protected]
Subject: Re: [edk2] [PATCH] ShellPkg: Update DH for AdapterInfoProtocol
We cannot duplicate them in the shell's DEC. someone else might actually make
a dependency on that and that would be bad.
What would you say to doing it like NT32 GUIDs and have them defined right in
the C file so only that one place can use them?
-Jaben
From: Tim Lewis [mailto:[email protected]]
Sent: Tuesday, November 25, 2014 4:33 PM
To: [email protected]<mailto:[email protected]>
Subject: Re: [edk2] [PATCH] ShellPkg: Update DH for AdapterInfoProtocol
Jaben -
Consider an ARM source delivery. Do we really a package full of Intel-isms
delivered? They never use those protocols and likely never will.
We can rebuild the shell entirely by itself, like a UEFI app, and it currently
depends only on MdePkg and MdeModulePkg.
My first choice would be just to leave them out. My next choice would be to
duplicate any extraneous values in the ShellPkg.dec
Tim
From: Carsey, Jaben [mailto:[email protected]]
Sent: Tuesday, November 25, 2014 4:18 PM
To: [email protected]<mailto:[email protected]>
Subject: Re: [edk2] [PATCH] ShellPkg: Update DH for AdapterInfoProtocol
I think that knowing the name of a produced protocol is pretty useful. The
only alternative I thought about is putting copies of the GUIDs in the shell.
What would you propose?
-Jaben
From: Tim Lewis [mailto:[email protected]]
Sent: Tuesday, November 25, 2014 4:14 PM
To: [email protected]<mailto:[email protected]>
Subject: Re: [edk2] [PATCH] ShellPkg: Update DH for AdapterInfoProtocol
Jaben, Samer -
Do we really want to make the shell dependent on the IntelFrameworkModulePkg?
Tim
From: Carsey, Jaben [mailto:[email protected]]
Sent: Tuesday, November 25, 2014 2:42 PM
To: [email protected]<mailto:[email protected]>
Subject: Re: [edk2] [PATCH] ShellPkg: Update DH for AdapterInfoProtocol
Reviewed-by: Jaben Carsey
<[email protected]<mailto:[email protected]>>
Commit 16445
p.s. I had to rework the commit message a little to get it past the "guard" or
whatever controls commit messages.
From: El-Haj-Mahmoud, Samer [mailto:[email protected]]
Sent: Tuesday, November 25, 2014 2:08 PM
To: [email protected]<mailto:[email protected]>
Subject: [edk2] [PATCH] ShellPkg: Update DH for AdapterInfoProtocol
Jaben,
Can you please review this and submit it?
Update Shell DH command to display gEfiAdapterInformationProtocolGuid and decode
information blocks defined in the UEFI 2.4 specification.
Also added GUIDs for gEfiIsaIoProtocolGuid and gEfiIsaAcpiProtocolGuid
protocols.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Samer El-Haj-Mahmoud [email protected]<mailto:[email protected]>
Thanks,
Samer El-Haj-Mahmoud
System Firmware Architect
HP Servers
[email protected]<mailto:[email protected]>
T +1.281.514.5973
C +1.512.659.1523
Hewlett-Packard Company
hp.com/go/proliant/uefi<http://hp.com/go/proliant/uefi>
[Description: Description: C:\Users\elhajmah\HpLogo.png]
------------------------------------------------------------------------------
Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server
from Actuate! Instantly Supercharge Your Business Reports and Dashboards
with Interactivity, Sharing, Native Excel Exports, App Integration & more
Get technology previously reserved for billion-dollar corporations, FREE
http://pubads.g.doubleclick.net/gampad/clk?id=164703151&iu=/4140/ostg.clktrk
_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/edk2-devel
