On 28/01/2015 00:29, Jordan Justen wrote: > They may be different, but looking, I'm wondering why > OvmfPkg/Library/QemuFwCfgLib doesn't have arm support, rather than > putting it into a separate module over in > ArmPlatformPkg/ArmVirtualizationPkg/Library/QemuFwCfgLib. > > It still may be valid to discuss whether it make sense to add to the > QemuFwCfgLib interface, but if they are able to be merged into a > single module, then maybe there would be less worry about code > duplication. > > To throw out another idea ... If it still feels like there should be a > separation between a library that accesses fw-cfg, and libraries than > make use of fw-cfg data: How about something like QemuFwCfgIoLib and > QemuFwCfgLib?
I agree. I think it would make sense, long term, that something like QemuFwCfgLib is in a new package QemuPkg, while different implementations of QemuFwCfgIoLib are in OvmfPkg and ArmPlatformPkg/ArmVirtualizationPkg. I guess this gives my opinion on your other question too. Paolo ------------------------------------------------------------------------------ Dive into the World of Parallel Programming. The Go Parallel Website, sponsored by Intel and developed in partnership with Slashdot Media, is your hub for all things parallel software development, from weekly thought leadership blogs to news, videos, case studies, tutorials and more. Take a look and join the conversation now. http://goparallel.sourceforge.net/ _______________________________________________ edk2-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/edk2-devel
