On 2015-04-21 13:13:49, Carsey, Jaben wrote: > Shumin, > > Can you review this?
What do you think about my advise to Eric here? http://permalink.gmane.org/gmane.comp.bios.tianocore.devel/13854 (Regarding To, Cc and asking for a review in patch emails.) > ShellPkg: add more info to function block. I think this updates the comments for GetHandleListByProtocol and GetHandleListByProtocolList, right? Maybe the function names should be mentioned in the commit message? What about something like? ShellPkg/HandleParsingLib: Caller should free memory from 2 functions Add a comment for GetHandleListByProtocol and GetHandleListByProtocolList to tell the caller they are responsible for freeing the returned memory. > Signed-off-by: Jaben Carsey <jaben.car...@intel.com> Contributed-under is misssing. -Jordan ------------------------------------------------------------------------------ BPM Camp - Free Virtual Workshop May 6th at 10am PDT/1PM EDT Develop your own process in accordance with the BPMN 2 standard Learn Process modeling best practices with Bonita BPM through live exercises http://www.bonitasoft.com/be-part-of-it/events/bpm-camp-virtual- event?utm_ source=Sourceforge_BPM_Camp_5_6_15&utm_medium=email&utm_campaign=VA_SF _______________________________________________ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel
