On 2015-04-22 08:01:28, Carsey, Jaben wrote: > I don’t mind making the changes to the commit message. > > Per your other thoughts: I think that if someone is expected to do > something with an email, then CCing that person is insufficient. A > CC is for a Carbon Copy in old lingo. I feel that this is equivalent > to a FYI with no action required. If I want someone to take action, > then I want to make that clear.
I see your point. For patches, it does seem like the meaning is slightly tweaked. It generally means that the sender would like some sort of feedback on the patch. Maybe they can test the patch, or review it... This must fall out of the fact that the standard practice is to send the patch *to* the list. Therefore, you can assume that everyone in the community has received the patch. The Cc field then has little purpose, and it has come to be used as a way to request notice and/or feedback. I think it's fine to add someone to the To field (instead of the Cc field) if you want to grab their attention, but I think people on the list should also come to expect that being Cc'd on a patch means that the sender would like their input. -Jordan > > -----Original Message----- > > From: Justen, Jordan L > > Sent: Tuesday, April 21, 2015 3:36 PM > > To: Carsey, Jaben; Qiu, Shumin > > Cc: edk2-devel@lists.sourceforge.net > > Subject: Re: [edk2] [PATCH] ShellPkg: add more info to function block. > > Importance: High > > > > On 2015-04-21 13:13:49, Carsey, Jaben wrote: > > > Shumin, > > > > > > Can you review this? > > > > What do you think about my advise to Eric here? > > http://permalink.gmane.org/gmane.comp.bios.tianocore.devel/13854 > > > > (Regarding To, Cc and asking for a review in patch emails.) > > > > > ShellPkg: add more info to function block. > > > > I think this updates the comments for GetHandleListByProtocol and > > GetHandleListByProtocolList, right? Maybe the function names should be > > mentioned in the commit message? > > > > What about something like? > > > > ShellPkg/HandleParsingLib: Caller should free memory from 2 functions > > > > Add a comment for GetHandleListByProtocol and > > GetHandleListByProtocolList to tell the caller they are responsible for > > freeing > > the returned memory. > > > > > Signed-off-by: Jaben Carsey <jaben.car...@intel.com> > > > > Contributed-under is misssing. > > > > -Jordan ------------------------------------------------------------------------------ BPM Camp - Free Virtual Workshop May 6th at 10am PDT/1PM EDT Develop your own process in accordance with the BPMN 2 standard Learn Process modeling best practices with Bonita BPM through live exercises http://www.bonitasoft.com/be-part-of-it/events/bpm-camp-virtual- event?utm_ source=Sourceforge_BPM_Camp_5_6_15&utm_medium=email&utm_campaign=VA_SF _______________________________________________ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel
