Reviewed-by: Eric Dong <eric.d...@intel.com>
-----Original Message-----
From: Laszlo Ersek [mailto:ler...@redhat.com]
Sent: Wednesday, May 13, 2015 6:54 PM
To: edk2-devel@lists.sourceforge.net
Cc: Dong, Eric
Subject: [PATCH] MdeModulePkg: ConfigKeywordHandler: fix pointer target
signedness
SVN r17428 ("MdeModulePkg: Implement UEFI25 HII Config keyword handler
protocol") introduced code that triggers
-Werror=pointer-sign
under gcc ("warn for pointer argument passing or assignment with different
signedness"). Fix up those locations.
Cc: Eric Dong <eric.d...@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek <ler...@redhat.com>
---
Notes:
Eric, if you are okay with the patch (as in, R-b), I can commit it
myself.
Thanks,
Laszlo
MdeModulePkg/Universal/HiiDatabaseDxe/ConfigKeywordHandler.c | 22
++++++++++----------
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigKeywordHandler.c
b/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigKeywordHandler.c
index 6a71540..c3cd064 100644
--- a/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigKeywordHandler.c
+++ b/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigKeywordHandler.c
@@ -806,7 +806,7 @@ GetStringIdFromString (
Offset = sizeof (EFI_HII_STRING_BLOCK);
StringTextPtr = BlockHdr + Offset;
BlockSize += Offset + AsciiStrSize ((CHAR8 *) StringTextPtr);
- if (AsciiStrCmp(AsciiKeywordValue, StringTextPtr) == 0) {
+ if (AsciiStrCmp(AsciiKeywordValue, (CHAR8 *) StringTextPtr) == 0)
+ {
*StringId = CurrentStringId;
goto Done;
}
@@ -816,7 +816,7 @@ GetStringIdFromString (
case EFI_HII_SIBT_STRING_SCSU_FONT:
Offset = sizeof (EFI_HII_SIBT_STRING_SCSU_FONT_BLOCK) - sizeof (UINT8);
StringTextPtr = BlockHdr + Offset;
- if (AsciiStrCmp(AsciiKeywordValue, StringTextPtr) == 0) {
+ if (AsciiStrCmp(AsciiKeywordValue, (CHAR8 *) StringTextPtr) == 0)
+ {
*StringId = CurrentStringId;
goto Done;
}
@@ -831,7 +831,7 @@ GetStringIdFromString (
for (Index = 0; Index < StringCount; Index++) {
BlockSize += AsciiStrSize ((CHAR8 *) StringTextPtr);
- if (AsciiStrCmp(AsciiKeywordValue, StringTextPtr) == 0) {
+ if (AsciiStrCmp(AsciiKeywordValue, (CHAR8 *) StringTextPtr) ==
+ 0) {
*StringId = CurrentStringId;
goto Done;
}
@@ -851,7 +851,7 @@ GetStringIdFromString (
for (Index = 0; Index < StringCount; Index++) {
BlockSize += AsciiStrSize ((CHAR8 *) StringTextPtr);
- if (AsciiStrCmp(AsciiKeywordValue, StringTextPtr) == 0) {
+ if (AsciiStrCmp(AsciiKeywordValue, (CHAR8 *) StringTextPtr) ==
+ 0) {
*StringId = CurrentStringId;
goto Done;
}
@@ -1069,7 +1069,7 @@ GetNextStringId (
if (*KeywordValue == NULL) {
return 0;
}
- AsciiStrToUnicodeStr(StringTextPtr, *KeywordValue);
+ AsciiStrToUnicodeStr ((CHAR8 *) StringTextPtr, *KeywordValue);
return CurrentStringId;
} else if (CurrentStringId == StringId) {
FindString = TRUE;
@@ -1088,7 +1088,7 @@ GetNextStringId (
if (*KeywordValue == NULL) {
return 0;
}
- AsciiStrToUnicodeStr(StringTextPtr, *KeywordValue);
+ AsciiStrToUnicodeStr ((CHAR8 *) StringTextPtr, *KeywordValue);
return CurrentStringId;
} else if (CurrentStringId == StringId) {
FindString = TRUE;
@@ -1109,7 +1109,7 @@ GetNextStringId (
if (*KeywordValue == NULL) {
return 0;
}
- AsciiStrToUnicodeStr(StringTextPtr, *KeywordValue);
+ AsciiStrToUnicodeStr ((CHAR8 *) StringTextPtr,
+ *KeywordValue);
return CurrentStringId;
} else if (CurrentStringId == StringId) {
FindString = TRUE;
@@ -1136,7 +1136,7 @@ GetNextStringId (
if (*KeywordValue == NULL) {
return 0;
}
- AsciiStrToUnicodeStr(StringTextPtr, *KeywordValue);
+ AsciiStrToUnicodeStr ((CHAR8 *) StringTextPtr,
+ *KeywordValue);
return CurrentStringId;
} else if (CurrentStringId == StringId) {
FindString = TRUE;
@@ -1674,7 +1674,7 @@ ConstructConfigHdr (
switch (((EFI_IFR_OP_HEADER *)OpCodeData)->OpCode) {
case EFI_IFR_VARSTORE_OP:
Guid = (EFI_GUID *)(UINTN *)&((EFI_IFR_VARSTORE *) OpCodeData)->Guid;
- AsciiName = ((EFI_IFR_VARSTORE *) OpCodeData)->Name;
+ AsciiName = (CHAR8 *) ((EFI_IFR_VARSTORE *) OpCodeData)->Name;
break;
case EFI_IFR_VARSTORE_NAME_VALUE_OP:
@@ -1684,7 +1684,7 @@ ConstructConfigHdr (
case EFI_IFR_VARSTORE_EFI_OP:
Guid = (EFI_GUID *)(UINTN *)&((EFI_IFR_VARSTORE_EFI *)
OpCodeData)->Guid;
- AsciiName = ((EFI_IFR_VARSTORE_EFI *) OpCodeData)->Name;
+ AsciiName = (CHAR8 *) ((EFI_IFR_VARSTORE_EFI *) OpCodeData)->Name;
break;
default:
@@ -2571,7 +2571,7 @@ EnumerateAllKeywords (
CHAR8 *LocalNameSpace;
EFI_STRING_ID NextStringId;
EFI_STATUS Status;
- CHAR8 *OpCode;
+ UINT8 *OpCode;
CHAR16 *ConfigRequest;
CHAR16 *ValueElement;
CHAR16 *KeywordResp;
--
1.8.3.1
------------------------------------------------------------------------------
One dashboard for servers and applications across Physical-Virtual-Cloud
Widest out-of-the-box monitoring support with 50+ applications
Performance metrics, stats and reports that give you Actionable Insights
Deep dive visibility with transaction tracing using APM Insight.
http://ad.doubleclick.net/ddm/clk/290420510;117567292;y
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel
