Thanks for the info. I didn't test it on NVMe-Qemu, I just run the change on a real production. I will do bigger scope test to see if it's valuable to add it back.
Thanks Feng From: Anbazhagan, Baraneedharan [mailto:anbazha...@hp.com] Sent: Tuesday, June 02, 2015 06:22 To: Tian, Feng; edk2-devel@lists.sourceforge.net Subject: RE: NVMe question Thanks for the update. NVMe used to work in QEMU and started failing now with this change. May be NVMe emulation issue in QEMU. -Baranee CONFIDENTIALITY NOTICE: The information contained in this e-mail and any accompanying documents may contain information which is HP confidential or otherwise protected from disclosure. This transmission may also be protected by the attorney-client privilege, the attorney work-product privilege, or both. If you are not the intended recipient of this message, or if this message has been addressed to you in error, please immediately alert the sender by reply e-mail and then delete this message, including any attachments. Any dissemination, distribution or other use of the contents of this message by anyone other than the intended recipient is strictly prohibited. From: Tian, Feng [mailto:feng.t...@intel.com] Sent: Sunday, May 31, 2015 9:54 PM To: Anbazhagan, Baraneedharan; edk2-devel@lists.sourceforge.net<mailto:edk2-devel@lists.sourceforge.net> Cc: Tian, Feng Subject: RE: NVMe question Hi, Baraneedharan Why I removed these two fields initialization is because NVMe spec 7.6.1 doesn't say it's mandatory. Do you see any real impact on this? Thanks Feng From: Anbazhagan, Baraneedharan [mailto:anbazha...@hp.com] Sent: Saturday, May 30, 2015 06:21 To: Tian, Feng; edk2-devel@lists.sourceforge.net<mailto:edk2-devel@lists.sourceforge.net> Subject: NVMe question With recent changes to NvmExpressDxe module, NvmeEnableController doesn't set I/O completion and submission queue size. Why default values are removed? CONFIDENTIALITY NOTICE: The information contained in this e-mail and any accompanying documents may contain information which is HP confidential or otherwise protected from disclosure. This transmission may also be protected by the attorney-client privilege, the attorney work-product privilege, or both. If you are not the intended recipient of this message, or if this message has been addressed to you in error, please immediately alert the sender by reply e-mail and then delete this message, including any attachments. Any dissemination, distribution or other use of the contents of this message by anyone other than the intended recipient is strictly prohibited.
------------------------------------------------------------------------------
_______________________________________________ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel
