On 06/03/15 02:24, Tian, Feng wrote: > Hi, Laszlo > > Most of us are using MS outlook as mail client. So top-posting is > inevitable per my knowledge. If you know how to avoid top posting, > please let us know.
The constructive answer would be http://home.in.tum.de/~jain/software/outlook-quotefix/ but checking the "compatibility" page, I doubt you guys use an outlook that old. The factually correct, but not so constructive answer would be that microsoft outlook is irreparably broken, and should not be used for participating in distributed, open source development. I'll point out that MS outlook is probably the source of further problems, not just top posting. For example, I'm fairly sure it doesn't allow you guys to save patch emails (posted with git) in pristine local files. It's broken quoting style also makes it impossible to produce "context sensitive" patch reviews, where you comment on the exact line or block of code that has a problem. (Hence, I can certainly see why someone would consider Gerrit a step forward. When your MUA is MS outlook, anything qualifies as an improvement.) These shortcomings likely apply to a bunch of other MUAs, like gmail (I assume), and most mobile clients. Same as most web apps, these tools are optimized for social interaction and "traditional productivity", not distributed development of technology. I probably can't convince you guys to ditch MS outlook; maybe it's a requirement forced upon you by your IT department, or perhaps you would lose connectivity with internal "productivity" tools if you did. (I've worked at a telco once where there was no way I could have ditched outlook myself.) So, I sincerely apologize for letting my annoyance show. In the future, I'll just seek to ignore top-posted messages, when I can afford that. Thanks Laszlo > -----Original Message----- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Tuesday, June 02, 2015 15:46 > To: edk2-devel@lists.sourceforge.net; Anbazhagan, Baraneedharan; Tian, Feng; > Busch, Keith > Cc: qemu devel list > Subject: Re: [edk2] NVMe question > > On 06/02/15 09:19, Tian, Feng wrote: >> Thanks for the info. >> >> >> >> I didn't test it on NVMe-Qemu, I just run the change on a real >> production. I will do bigger scope test to see if it's valuable to add >> it back. > > This email thread is a perfect example why top-posting is a horrible practice. > > The NVMe device model was developed for QEMU by Intel's own Keith Busch > (added to the address list). Now Keith will have to read this email in > reverse. (A good portion of which consists of confidentiality notices, posted > to a public mailing list.) Good luck. > > Keith, here's the thread, if it helps: > http://thread.gmane.org/gmane.comp.bios.tianocore.devel/15073 > > The issue seems to be that > > https://github.com/tianocore/edk2/commit/d6c55989 > > removed the nonzero initialization of Cc.Iosqes (submission queue size?) and > Cc.Iocqes (completion queue size?) in function NvmeEnableController(). And > the removal of these field initializations seems to cause the early sanity > check in QEMU's nvme_start_ctrl() to fail -- my guess at least. > > The question is now if QEMU is right (according to the NVMe spec) to require > those fields, or if edk2 is right not to initialize them. > > (On the side, let me point out that even if this edk2 change was justified, > it definitely should have been a separate patch, because it has nothing to do > with "Expose EFI_NVM_EXPRESS_PASS_THRU protocol".) > > Let me break it down for the 1000th time: > - don't top post > - write focused patches > > PLEASE! It's not 1980 any longer. > > Thanks > Laszlo > >> >> Thanks >> >> Feng >> >> >> >> *From:* Anbazhagan, Baraneedharan [mailto:anbazha...@hp.com] >> *Sent:* Tuesday, June 02, 2015 06:22 >> *To:* Tian, Feng; edk2-devel@lists.sourceforge.net >> *Subject:* RE: NVMe question >> >> >> >> Thanks for the update. NVMe used to work in QEMU and started failing >> now with this change. May be NVMe emulation issue in QEMU. >> >> >> >> -Baranee >> >> >> >> CONFIDENTIALITY NOTICE: The information contained in this e-mail and >> any accompanying documents may contain information which is HP >> confidential or otherwise protected from disclosure. This transmission >> may also be protected by the attorney-client privilege, the attorney >> work-product privilege, or both. If you are not the intended recipient >> of this message, or if this message has been addressed to you in >> error, please immediately alert the sender by reply e-mail and then >> delete this message, including any attachments. Any dissemination, >> distribution or other use of the contents of this message by anyone >> other than the intended recipient is strictly prohibited. >> >> >> >> *From:* Tian, Feng [mailto:feng.t...@intel.com] >> *Sent:* Sunday, May 31, 2015 9:54 PM >> *To:* Anbazhagan, Baraneedharan; edk2-devel@lists.sourceforge.net >> <mailto:edk2-devel@lists.sourceforge.net> >> *Cc:* Tian, Feng >> *Subject:* RE: NVMe question >> >> >> >> Hi, Baraneedharan >> >> >> >> Why I removed these two fields initialization is because NVMe spec >> 7.6.1 doesn't say it's mandatory. >> >> >> >> Do you see any real impact on this? >> >> >> >> Thanks >> >> Feng >> >> >> >> *From:* Anbazhagan, Baraneedharan [mailto:anbazha...@hp.com] >> *Sent:* Saturday, May 30, 2015 06:21 >> *To:* Tian, Feng; edk2-devel@lists.sourceforge.net >> <mailto:edk2-devel@lists.sourceforge.net> >> *Subject:* NVMe question >> >> >> >> With recent changes to NvmExpressDxe module, NvmeEnableController >> doesn't set I/O completion and submission queue size. Why default >> values are removed? >> >> >> >> >> >> CONFIDENTIALITY NOTICE: The information contained in this e-mail and >> any accompanying documents may contain information which is HP >> confidential or otherwise protected from disclosure. This transmission >> may also be protected by the attorney-client privilege, the attorney >> work-product privilege, or both. If you are not the intended recipient >> of this message, or if this message has been addressed to you in >> error, please immediately alert the sender by reply e-mail and then >> delete this message, including any attachments. Any dissemination, >> distribution or other use of the contents of this message by anyone >> other than the intended recipient is strictly prohibited. >> >> >> >> >> >> ---------------------------------------------------------------------- >> -------- >> >> >> >> _______________________________________________ >> edk2-devel mailing list >> edk2-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/edk2-devel >> > ------------------------------------------------------------------------------ _______________________________________________ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel
