On 5 June 2015 at 06:03, Roy Franz <roy.fr...@linaro.org> wrote: > On Thu, May 14, 2015 at 1:57 PM, Kinney, Michael D > <michael.d.kin...@intel.com> wrote: >> Roy, >> >> 1) New GUID should be defined in MdeModulePkg/MdeModulePkg.dec >> 2) New include file for new GUID in MdeModulePkg/Include/Guid >> 3) Update TerminalDxe to use this new GUID. >> >> I do not recommend creating a new terminal driver. Please continue as you >> have which is adding support for this one new terminal type to >> MdeModulePkg/Universal/Console/TerminalDxe. >> >> Best regards, >> >> Mike >> >> > OK, I have made the above changes, and have it working with one hack > I'm not sure how to properly resolve. > > I now have gEfiTtyTermGuid declared (extern) in > MdeModulePkg/Include/Guid/TtyTerm.h, and defined in > MdeModulePkg/Universal/Console/TerminalDxe/Tty.c. > > I use gEfiTtyTermGuid in DevicePathFromText.c in MdePkg to convert > between a text path to a device path, but > I don't see how to include TtyTerm.h in DevicePathFromText.c. Right > now I just have added the extern to DevicePathFromText.c > to verify functionality. This works, but is obviously not the right > solution. How should I go about properly getting gEfiTtyTermGuid > declared in DevicePathFromText.c? >
You should not define the GUID yourself, you should add it to the appropriate .dec file, If you then depend on that package and guid in a module's .inf, the definition will be emitted implicitly by the build tools. -- Ard. ------------------------------------------------------------------------------ _______________________________________________ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel
