On 2015-07-10 00:29:18, Wu, Jiaxin wrote: > I agree your suggested format absolutely. Sorry for my missing any attention. > > I'm not "Cc" any maintainer manually. We should know that the Cc > part maintainers in commit message will be ignored by edk2-devel if > the maintainers already in edk2-devel mailing list.
You mean edk2-devel will strip it? Maybe there is a list setting to look at. Anyway, I think the Cc will still go directly to the Cc'd addresses. > So, if we want > to send out the patch to someone personally, we must need to specify > the maintainers with “--to xxx” in git bash. Fortunately for git, it > support the script format, which also can help us save a lot of time > when have multiple versions of the patch series. How does this work? Anyway, I'd still like to figure out if there are problems using the standard Cc method. -Jordan > -----Original Message----- > From: Justen, Jordan L > Sent: Friday, July 10, 2015 2:48 PM > To: Wu, Jiaxin; edk2-devel@lists.sourceforge.net; af...@apple.com > Subject: Re: [PATCH v3 3/7] EmulatorPkg: Remove Ip4ConfigDxe module from > EmulatorPkg > > When you send new versions of the patch series, can you not reply to the > previous version? Then discussions for each version of the series can happen > separately. (It also makes v3 get a little hidden in the old v1/v2 emails.) > > On 2015-07-09 00:24:34, Jiaxin Wu wrote: > > Version3 continue to update with a proper commit message. > > I guess you don't agree with my suggested format? > > v3: > * Update with a proper commit message > > > Ip4ConfigDxe driver is deprecated in UEFI 2.5, so we will not support > > original Ip4Config Protocol, which is replace by Ip4Config2 Protocol > > integrated in Ip4Dxe driver(git commit 1f6729ff (SVN r17853)).Therefore we > > can remove Ip4ConfigDxe driver from this build. > > This commit message line is too long: > > https://github.com/tianocore/tianocore.github.io/wiki/Commit-Message-Format > > > Contributed-under: TianoCore Contribution Agreement 1.0 > > Signed-off-by: Jiaxin Wu <jiaxin...@intel.com> > > I guess you Cc'd Andrew and I manually? > > If you add "Cc: Jordan Justen <jordan.l.jus...@intel.com>" to the commit > message, then git send-email will automatically add the Cc's when sending the > email. It can save a lot of time when you have multiple versions of the patch > series. > > Anyway, I guess with the long commit message lines fixed, then patches > 3 & 5 Reviewed-by: Jordan Justen <jordan.l.jus...@intel.com> > > > --- > > EmulatorPkg/EmulatorPkg.dsc | 1 - > > EmulatorPkg/EmulatorPkg.fdf | 3 +-- > > 2 files changed, 1 insertion(+), 3 deletions(-) > > > > diff --git a/EmulatorPkg/EmulatorPkg.dsc b/EmulatorPkg/EmulatorPkg.dsc > > index b16fcac..e0c6161 100644 > > --- a/EmulatorPkg/EmulatorPkg.dsc > > +++ b/EmulatorPkg/EmulatorPkg.dsc > > @@ -355,11 +355,10 @@ > > # Network stack drivers > > # > > MdeModulePkg/Universal/Network/DpcDxe/DpcDxe.inf > > MdeModulePkg/Universal/Network/ArpDxe/ArpDxe.inf > > MdeModulePkg/Universal/Network/Dhcp4Dxe/Dhcp4Dxe.inf > > - MdeModulePkg/Universal/Network/Ip4ConfigDxe/Ip4ConfigDxe.inf > > MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Dxe.inf > > MdeModulePkg/Universal/Network/MnpDxe/MnpDxe.inf > > MdeModulePkg/Universal/Network/VlanConfigDxe/VlanConfigDxe.inf > > MdeModulePkg/Universal/Network/Mtftp4Dxe/Mtftp4Dxe.inf > > MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Dxe.inf > > diff --git a/EmulatorPkg/EmulatorPkg.fdf b/EmulatorPkg/EmulatorPkg.fdf > > index 83b1de6..a002389 100644 > > --- a/EmulatorPkg/EmulatorPkg.fdf > > +++ b/EmulatorPkg/EmulatorPkg.fdf > > @@ -1,9 +1,9 @@ > > ## @file > > # This is Emulator FDF file with UEFI HII features enabled # -# > > Copyright (c) 2008 - 2013, Intel Corporation. All rights reserved.<BR> > > +# Copyright (c) 2008 - 2015, Intel Corporation. All rights > > +reserved.<BR> > > # Portions copyright (c) 2009 - 2011, Apple Inc. All rights > > reserved.<BR> # # This program and the accompanying materials # are > > licensed and made available under the terms and conditions of the BSD > > License # which accompanies this distribution. The full text of the > > license may be found at @@ -194,11 +194,10 @@ INF > > MdeModulePkg/Application/HelloWorld/HelloWorld.inf > > INF EmulatorPkg/EmuSnpDxe/EmuSnpDxe.inf > > !endif > > INF MdeModulePkg/Universal/Network/DpcDxe/DpcDxe.inf > > INF MdeModulePkg/Universal/Network/ArpDxe/ArpDxe.inf > > INF MdeModulePkg/Universal/Network/Dhcp4Dxe/Dhcp4Dxe.inf > > -INF MdeModulePkg/Universal/Network/Ip4ConfigDxe/Ip4ConfigDxe.inf > > INF MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Dxe.inf > > INF MdeModulePkg/Universal/Network/MnpDxe/MnpDxe.inf > > INF MdeModulePkg/Universal/Network/VlanConfigDxe/VlanConfigDxe.inf > > INF MdeModulePkg/Universal/Network/Mtftp4Dxe/Mtftp4Dxe.inf > > INF MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Dxe.inf > > -- > > 1.9.5.msysgit.1 > > ------------------------------------------------------------------------------ Don't Limit Your Business. Reach for the Cloud. GigeNET's Cloud Solutions provide you with the tools and support that you need to offload your IT needs and focus on growing your business. Configured For All Businesses. Start Your Cloud Today. https://www.gigenetcloud.com/ _______________________________________________ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel
