Hi Max and all! > On 08/10/2021 17:22, Marco Wahl wrote: >> Max Nikulin writes: >>> On 05/10/2021 23:32, Ihor Radchenko wrote: >>>> Max Nikulin writes: >>>> I tried come up with the reason why org-no-popup was used in the >>>> initial >>>> implementation. I think, the reason is avoiding situation like what you >>>> may see after running >>>> (let ((pop-up-frames t)) (funcall-interactively #'org-goto)) >>>> So, removing the macro completely is not a good idea. >>>> I have updated the patch that should work without dropping the >>>> macro. >>>> See the attached. >> >> Please note the documentation of variable `pop-up-windows'. >> >> This variable is provided mainly for backward compatibility and >> should not be used in new code. >> >> The same holds for `pop-up-frames'. >> >> The drop of the macro looks like a good idea to me. Can someone please >> describe the price for dropping macro `org-no-popups'? >> >> @Ihor I do not understand what "situation" you mean. > > Marco, have you tried > (setq pop-up-frames t) > with first version of patch? It shows help in a new separate frame. > Unsure if it is expected behavior even with such customization. > > However current version of macro does not protect against > > (setq display-buffer-base-action > '((display-buffer-reuse-window display-buffer-pop-up-frame) > (reusable-frames . 0))) > > The example is taken from (info "(elisp) Choosing Window Options"). I > have no idea if such customization can be considered as shooting a foot.
TBH I don't fully understand that display-buffer stuff. I experimented a little with regards to org-goto. AFAICT org-goto does a good job without macro org-no-popups. IIUC the use of macro org-no-popups in org-goto shall "protect" the org-goto user interface in some sense. You already mentioned that. My feeling is that the "protection" is good intention but brings more harm than good. I think it's not a good idea to enforce a certain window setting. I guess the knowing user has an easier path to fine tune the org-goto user interface when there is less "protection". > http://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=399481bad10845a77f210c9320ff1efee9a312c8 > that caused the current problem changed namely `pop-up-windows' Thanks for the link! AFAICT the change in org-macs.el should not be in that commit since it has nothing to do with org links -- which are the actual concern of that commit. And indeed the change in org-macs.el of that commit broke the org-goto interface some. Summary: The org-goto interface today is somewhat broken. I vote for taking the occasion and kicking out the macro org-no-popups entirely. This way the org-goto interface is functional AFAICS. If problems occur on that path we'll take care and action. Do you agree? Regards, -- Marco