> Thanks! > May you attach the patch as a separate attachment next time? > I was not able to apply this email patch automatically.
Sorry, I'm apparently not used to reading issue threads outside of Github. I read too fast and missed everything after this. >>> Adding back standard properties to the loop reduces performance by 5-20% >> depending on the element (see attached), but that's taking off of an already >> 5-10x speedup (see attached pdf). >> >> Then, I'd rather not make assumptions about keywords being or not being >> in standard properties. To avoid subtle bugs in the future. >> >> An alternative approach to address searching affiliated keyword >> properties could be storing the list of all the affiliated keyword >> property names in a special property. Like what is done for :secondary. In this case, I'll revise the patch to keep :standard-properties in the loop. There are minor optimizations we could make in addition, but it sounds like these would require more coordination of where/how we store affiliated keywords. ________________________________ From: Ihor Radchenko <yanta...@posteo.net> Sent: Sat, 12 Apr 2025 06:37:15 +0000 (16 hours, 31 minutes, 27 seconds ago) To: Dwarshuis, Nathan J Subject: [PATCH] org-element.el; significant optimizations for org-element--interpret-affiliated-keywords Ihor Radchenko <yanta...@posteo.net> writes: >> Adding back standard properties to the loop reduces performance by 5-20% > depending on the element (see attached), but that's taking off of an already > 5-10x speedup (see attached pdf). > > Then, I'd rather not make assumptions about keywords being or not being > in standard properties. To avoid subtle bugs in the future. > > An alternative approach to address searching affiliated keyword > properties could be storing the list of all the affiliated keyword > property names in a special property. Like what is done for :secondary. > ... It has been a while since the last activity in this thread. Nathan, may I know if you had a chance to look into my comments?
