"Dwarshuis, Nathan J" <nd...@yavin4.ch> writes:

>> This is not TINYCHANGE as it is a lot more than 15LOC.
>
> fixed

Another effect of the patch exceeding 15LOC is that I now need you to go
through the copyright assignment before I can accept it.
Would you be interested to do it?
See https://orgmode.org/worg/org-contribute.html#copyright

>> Now, you no longer need to call internal function. Just use
>> `org-element-properties-mapc'.
>
> fixed, although I wasn't sure if 'force should be used here

I think just non-nil value will do.
'force will also modify the ELEMENT by side effect, which may not be
desired.

> +           (let* ((keyword (upcase (substring (symbol-name prop) 1)))
> +                  (attrp (string-match-p "^ATTR_" keyword)))

Nitpick: `string-prefix-p' will be slightly faster as it does not
require running the regexp engine.

-- 
Ihor Radchenko // yantar92,
Org mode maintainer,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

Reply via email to