"Dwarshuis, Nathan J" <nd...@yavin4.ch> writes:

> revised/rebased patch attached which no longer skips standard props

Thanks!

> * lisp/org-element.el (org-element--interpret-affiliated-keywords):
> Optimize performance by bypassing unnecessary types and reducing
> loop complexity. Added new constant
> `org-element-elements-no-affiliated` which stores the types to
> be bypassed.

Please use double space between sentences and `quote' like this, not
`like this`. See https://orgmode.org/worg/org-contribute.html#commit-messages

> Second, the loop was much more complex than needed. The loop included
> :standard-properties which should not be necessary here. It also
> duplicated some work between calls to `org-element--properties-mapc`
> and `mapconcat` (the code was moved entirely under the former). The
> result should be faster and more readable.

This part of the commit message should probably be dropped as you
removed this part from the code.

> TINYCHANGE

This is not TINYCHANGE as it is a lot more than 15LOC.

> +      (org-element-properties-resolve element t)
> +      (org-element--properties-mapc

Now, you no longer need to call internal function. Just use
`org-element-properties-mapc'.

-- 
Ihor Radchenko // yantar92,
Org mode maintainer,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

Reply via email to