Better use testing/lisp/text-ox-md.el header that does not have such line.
Adapted it accordingly.
Regarding the prefix-topic: I was a bit confused with that and thought that this must be some sort of "special test convention" that I am not aware of. Sorry for that, and thanks for clarifying. I revised the respective parts.
Finally, `with-try-set-dotnet-version' is questionable. It is used once so you may as well put the code directly inside `with-newest-dotnet'.
Agreed, I inlined this.
`test-ob-csharp-with-newest-dotnet' may benefit from (declare (indent 1))
Yes, that is indeed nicer.
1. There is no need to document :dir header argument. It is already
described in the main Org manual.
I removed that from the docs.
I thought about that and came to the conclusion that I consider the "yes" argument as bloat, so I removed that as an option completely.2. :main yes does not appear to be test-covered unless I miss something
3. :nugetconfig is not test-covered
For some reason, I did not commit that. It is there now, see https://codeberg.org/buoso/csharp-babel/src/commit/9a8745b77d94fbacd47de1415e616bd8e4878103/test-ob-csharp.el#L221-L242
4. :framework is not test-covered
Added a test https://codeberg.org/buoso/csharp-babel/src/commit/8bfe402122e48b0145deef86772310d47aa17efa/test-ob-csharp.el#L280-L293
5. :class is not test-covered (when set to a string)
Added a test https://codeberg.org/buoso/csharp-babel/src/commit/8bfe402122e48b0145deef86772310d47aa17efa/test-ob-csharp.el#L84-L92 On 19.04.25 15:54, Ihor Radchenko wrote:
poverobuosodonati <poverobuosodon...@gmail.com> writes:1. Let's call the file a part of Emacs (we plan to move tests to Emacs eventually)For this I would need some additional support as I don't exactly understand what you mean here. Do you mean where to put it as in like "emacs/test/lisp" instead of "org-mode/testing/lisp"?No. I was mostly objecting "this file is not a part of Emacs" line. Better use testing/lisp/text-ox-md.el header that does not have such line. (This thing is rather minor)2. Please prefix the macro and function names (with-...)Done.Sorry, I was not clear. I asked you to use a unique prefix, not just with-... prefix. Something like (test-ob-csharp-with-... ...) See D.1 Emacs Lisp Coding Conventions section of Elisp manual. Also, "with-" specifically is mostly used for macros. I did not mean to rename functions (it makes no sense there). Finally, `with-try-set-dotnet-version' is questionable. It is used once so you may as well put the code directly inside `with-newest-dotnet'. Here is what I suggest: 1. Rename `with-find-dotnet-version' to `test-ob-csharp--find-dotnet-version' 2. Rename `system-dotnet-version' to `test-ob-csharp-system-dotnet-version' 3. Get rid of `with-try-set-dotnet-version' inlining its code directly into `with-newest-dotnet' 4. Rename `with-newest-dotnet' to `test-ob-csharp-with-newest-dotnet' 5. `test-ob-csharp-with-newest-dotnet' may benefit from (declare (indent 1)) Also, few more comments on the documentation + tests: 1. There is no need to document :dir header argument. It is already described in the main Org manual. 2. :main yes does not appear to be test-covered unless I miss something 3. :nugetconfig is not test-covered 4. :framework is not test-covered 5. :class is not test-covered (when set to a string)
