poverobuosodonati <poverobuosodon...@gmail.com> writes:

>> Finally, `with-try-set-dotnet-version' is questionable. It is used once
>> so you may as well put the code directly inside `with-newest-dotnet'.
> Agreed, I inlined this.

Another note here: you may probably use `unwind-protect' instead of
progn to be safe.
https://codeberg.org/buoso/csharp-babel/src/branch/dev/test-ob-csharp.el#L113

>> 2. :main yes does not appear to be test-covered unless I miss something
> I thought about that and came to the conclusion that I consider the 
> "yes" argument as bloat, so I removed that as an option completely.

Does it mean what an equivalent of a "yes" is now no header argument at
all? That's not a good idea. Consider header argument set for a subtree:
* Heading
:PROPERTIES:
:HEADER-ARGS:CSHARP: :main no
:END:
...
# :main yes just for this block
#+begin_src csharp :main yes
...
#+end_src

-- 
Ihor Radchenko // yantar92,
Org mode maintainer,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

Reply via email to