Ihor Radchenko <[email protected]> writes:

Morgan Smith <[email protected]> writes:

repro: SKIP_CLEANPKG = yes
repro: cleanall autoloads
        -@$(REPRO) &

So, nothing in make repro actually tests that compat is installed. Emacs loads, tries to load Org, and fails to (require 'compat).

Shoot. Ya you right. Just slap a "checkpkg" into the dependencies there and we should be right as rain.

Maybe even uppkg. make repro is aimed to "just work", so more automation should be beneficial.

We haven't even merged this patchset and it's already showing quirks from its evolution :P

The only reason we have a separate uppkg and checkpkg is because originally uppkg was going to do a network call. Now that it's entirely local we should just replace checkpkg with uppkg everywhere.

This also made me think about what users are going to see after git clone. I think we should also update instructions to use git clone --recurse-submodules. WDYT?

I'd be curious on how many people compile from the repo without first obtaining a modern Emacs. I'm not against it but I don't think it's necessary. Personally, I'd use the command "git clone --recurse-submodules --shallow-submodules"

Reply via email to