Nicolas Goaziou <n.goaz...@gmail.com> writes: > Hello, > > Eric Abrahamsen <e...@ericabrahamsen.net> writes: > >>> Right now I'm seeing breakage with `org-set-property' -- this only >>> happens on the indentation patches branch. Adding an EXPORT_AUTHOR >>> property with that command, value of "asdfadsf", gives me this: >>> >>> * Test Heading >>> :PROPERTIES: >>> >>> :EXPORT_AUTHOR: asdfasdfnil nil >>> >>> Extra blank nil, spurious "nils", and no :END: > > [...] > >> Specifically, in this section of `org-indent-line': >> >> (when (eq type 'node-property) >> (let ((column (current-column))) >> (save-excursion >> (beginning-of-line) >> (looking-at org-property-re)) >> (replace-match (concat (match-string 4) >> (format org-property-format >> (match-string 1) >> (match-string 3))) >> t t) >> (org-move-to-column column))) >> >> Those match-string calls toward the end both return "nil", and the >> "nil"s get inserted directly into the buffer. I tried this with a >> minimal setup (load-paths only, and a blank Org file) and could >> reproduce. > > Indeed. I attach a replacement for both patch 1 and 2.
One other thing: I was going to poke around with code block indentation and see if I could break it, but I can't get the third patch to apply cleanly any more. I don't know if it's because I rebased this testing branch against an update master, or if your changes to the first two patches mean the third needs to be edited accordingly... It fails at org.el:22368, which is this line inside `org-indent-line': (skip-chars-backward " \r\t\n") Perhaps we need a new version of patch 3? Eric