On 26 September 2011 11:05, andy pugh <bodge...@gmail.com> wrote: > The behaviour seems to be encoded in interp_convert.cc, lines > 4365-4366 and 4399-4400. > If safe_x is safe, why add/subtract anything from it, why not just > move back to it, and retract?
This patch seems to make the G76 preview look a little more like what one might expect. I haven't tried threading with it, but don't foresee any problems. I think the current behaviour explains problems I have had with internal lathe threading. It also does remove that funny little wrong-way-wiggle at the beginning of the cycle. Does anyone know why the current return passes are offset by the cut depth? -------------------- [PATCH] Simplify G76 threading. This patch makes all return moves happen along the "drive line". This makes it easier to do tight-clearance internal threading. Signed-off-by: Andy Pugh <a...@bodgesoc.org> --- src/emc/rs274ngc/interp_convert.cc | 10 ++-------- 1 files changed, 2 insertions(+), 8 deletions(-) diff --git a/src/emc/rs274ngc/interp_convert.cc b/src/emc/rs274ngc/interp_convert.cc index 026eac0..e2c3f2b 100644 --- a/src/emc/rs274ngc/interp_convert.cc +++ b/src/emc/rs274ngc/interp_convert.cc @@ -4072,10 +4072,7 @@ threading_pass(setup_pointer settings, block_pointer block, double start_y, double start_z, double zoff, double taper_dist, int entry_taper, int exit_taper, double taper_pitch, double pitch, double full_threadheight, double target_z) { - STRAIGHT_TRAVERSE(block->line_number, boring? - safe_x + depth - end_depth: - safe_x - depth + end_depth, - start_y, start_z - zoff, AABBCC); //back + STRAIGHT_TRAVERSE(block->line_number, safe_x, start_y, start_z - zoff, AABBCC); //back if(taper_dist && entry_taper) { DISABLE_FEED_OVERRIDE(); START_SPEED_FEED_SYNCH(taper_pitch, 0); @@ -4106,10 +4103,7 @@ threading_pass(setup_pointer settings, block_pointer block, start_y, target_z - zoff, AABBCC); //over } STOP_SPEED_FEED_SYNCH(); - STRAIGHT_TRAVERSE(block->line_number, boring? - safe_x + depth - end_depth: - safe_x - depth + end_depth, - start_y, target_z - zoff, AABBCC); //out + STRAIGHT_TRAVERSE(block->line_number, safe_x, start_y, target_z - zoff, AABBCC); //out ENABLE_FEED_OVERRIDE(); } -- 1.7.0.4 -- atp "Torque wrenches are for the obedience of fools and the guidance of wise men" ------------------------------------------------------------------------------ All the data continuously generated in your IT infrastructure contains a definitive record of customers, application performance, security threats, fraudulent activity and more. Splunk takes this data and makes sense of it. Business sense. IT sense. Common sense. http://p.sf.net/sfu/splunk-d2dcopy1 _______________________________________________ Emc-developers mailing list Emc-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/emc-developers