On 10/25/12 04:09 , Victor Rocco wrote: > I did the homework. > There are only 4 programs that uses modbus communications: 1) classicladder > 2) gs2_vfd 3) vfs11_vfd 4) mb2hal. > 1) classicladder have their own implementation of modbus. So will NOT be > affected by the patch. > 2) gs2_vfd uses the modbus functions 0x06 preset_single_register and 0x03 > read_holding_registers. So will NOT be affected by the patch, that fix > functions 0x0F force_multiple_coils and 0x02 read_imput_status. > 3) vfs11_vfd uses libmodbus3. So will NOT be affected by the patch. > 4) mb2hal needs the patch. > > I am confident that you could apply the patch (0002-A-.....) to master > WITHOUT problems. > Just to be sure, i will be glad if you do some test with your own GS2 drive. >
Thanks for that investigation, looks like it's safe to apply the patch. I'll apply it in master and test it on my GS2 VFD either tonight or early next week. If it works for me i'll push it. We already know mb2hal work with it (and even needs it), and you just discovered that no other software uses modbus.c, so i think we'll be good to go. Thanks for your work on this. :-) -- Sebastian Kuzminsky ------------------------------------------------------------------------------ Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_sfd2d_oct _______________________________________________ Emc-developers mailing list Emc-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/emc-developers