-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 7/2/2013 10:42 AM, Sebastian Kuzminsky wrote: > > 1: > http://buildbot.linuxcnc.org/doc/scratch/v2.5.2~contributor-docs-1~f892e30/html/code/Contributing-to-LinuxCNC.html
Looks > great! One thing I would add is in step 3 where you say "Push your branch to a publicly visible git repo", I would mention it's OK to use something like github or bitbucket, since most folks probably don't have their own publicly visible git server. By way of comparison, I think the Slic3r folks are doing a good job of this...their main web page has a "Fork me on github" link: http://slic3r.org/ ...it's totally clear they want you to clone the code and submit changes. Perhaps a "Fork me with git" link somewhere on www.linuxcnc.org? It doesn't have to be the main page, but I think there should be something like this on the download page where the source code is referenced. > I have a couple of thoughts on this documentation. > > I don't think the LinuxCNC project should run a school on how to > use git. There are many other excellent git tutorials that do a > very good job of this already, and the best ones I've found are > linked in the first section of the "Using Git" document. I agree. I didn't completely read the git wiki page primarily because it seemed to be a "how to use git", and it wasn't until the bottom that it became "how to submit a git pull request to the LinuxCNC developers". ...and there still isn't much on the wiki git page for guidance if you're doing something more than minor patching (ie: the listed process seems like it would work well for a new HAL component or quick bug fix, but not for supporting a new RTOS, for example). But the new documentation is looking good! - -- Charles Steinkuehler char...@steinkuehler.net -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (MingW32) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iEYEARECAAYFAlHS+coACgkQLywbqEHdNFyi3ACg5V3fsKZVryIUxOa2942yIu+C K1oAoJX3YcZC5qpTAZEGLjkO+0lmUIGI =xAoH -----END PGP SIGNATURE----- ------------------------------------------------------------------------------ This SF.net email is sponsored by Windows: Build for Windows Store. http://p.sf.net/sfu/windows-dev2dev _______________________________________________ Emc-developers mailing list Emc-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/emc-developers
