So valid numbers would be 1-100? JT
On 6/30/2014 1:44 AM, Marius Liebenberg wrote: > Sorry bad commenting on my part. It is the rate at which the THC will > correct by. It is the THC correction speed as a percentage of the > requested velocity. > > On 2014-06-29 23:30, John Thornton wrote: >> What is the speed input? >> >> JT >> >> On 6/29/2014 8:31 AM, Marius Liebenberg wrote: >>> Can be deleted but is handy to debug the process with for a new user. I >>> did not clean up the comp properly yet >>> On 2014-06-29 14:58, John Thornton wrote: >>>> What does out pins s1-s4 do? >>>> >>>> JT >>>> >>>> On 6/29/2014 7:28 AM, Marius Liebenberg wrote: >>>>> JT >>>>> I attached the component. It has been used as it is now and it works >>>>> fine. I dont mind standing in for it. I will be testing it some more >>>>> very soon on a real system so if there are any funnies, I will fix and >>>>> report back. If you are not comfortable with it this way I could >>>>> always submit a new component but I think that would be non productive. >>>>> >>>>> Maybe just to clarify the added line of code. It applies a change in >>>>> the Z command over a period of time in stead of applying the new >>>>> position in one go. This means that Z axis get a chance to change at a >>>>> reasonable rate and leave very little chance of the motor slipping. It >>>>> sort of simulates a controlled acceleration slope. >>>>> If we dont do this and the machine is set to a fast cutting speed >>>>> (velocity), the z axis will sometimes slip as the acceleration >>>>> parameters are not adhered to. This solution does not adhere to the >>>>> acceleration parameters either but it implements the change at a >>>>> programmable slope as a percentage of the requested velocity. >>>>> >>>>> I hope this make more sense now. >>>>> >>>>> >>>>> On 2014-06-29 14:16, John Thornton wrote: >>>>>> I'm sorry but I'm not following you or I'm confused or both. If you >>>>>> could post the complete component that might help. >>>>>> >>>>>> Just because I managed to hack this component out by trial and error >>>>>> doesn't mean I feel like I own it in any way shape or form and would >>>>>> welcome anyone with more programming smarts to make changes to it to >>>>>> make it better. I don't feel comfortable making changes I don't >>>>>> understand. I really wish someone like Jeff would give it a once over >>>>>> and make any changes they see fit. >>>>>> >>>>>> JT >>>>>> >>>>>> On 6/27/2014 4:07 PM, Marius Liebenberg wrote: >>>>>>> On 2014-06-27 22:53, John Thornton wrote: >>>>>>>> Marius, >>>>>>>> >>>>>>>> Are you dropping the correction_velocity parameter? I'm confused. >>>>>>> Not dropping it but making it rate dependant >>>>>>> >>>>>>> #### This is the corrected line that was there >>>>>>> min_velocity = requested_vel - ( requested_vel >>>>>>> -(requested_vel*(velocity_tol/100))); >>>>>>> #### and this is what I added. It applies the velocity change over a >>>>>>> period of time to simulate acceleration >>>>>>> correction_vel= ((requested_vel *(speed / 100)) * fperiod)/10; >>>>>>> >>>>>>> This way the correction velocity becomes a percentage of the requested >>>>>>> velocity. It is applied over a period of time in order to prevent the >>>>>>> stepper to slip if the change it to big all at once. This might not be >>>>>>> an issue with servo systems but definitely with steppers. It is a >>>>>>> similar implementation approach that was followed in Mach. >>>>>>> >>>>>>> Hope this make sense. It did implement this on several systems with >>>>>>> great results. >>>>>>> >>>>>>>> JT >>>>>>>> >>>>>>>> On 6/27/2014 12:53 PM, Marius Liebenberg wrote: >>>>>>>>> Seb >>>>>>>>> That fixes some of the problem. If you can ask John to look at the >>>>>>>>> extra >>>>>>>>> line of code I added to make the velocity change at a rate that is a >>>>>>>>> percentage of the requested velocity instead of banging the >>>>>>>>> velocity to >>>>>>>>> the next value. The fix is attached to the comment in the ticket >>>>>>>>> manager. If he can look at that and comment please. >>>>>>>>> >>>>>>>>> >>>>>>>>> On 2014-06-27 19:08, Sebastian Kuzminsky wrote: >>>>>>>>>> On 6/27/14 05:22 , Marius Liebenberg wrote: >>>>>>>>>>> I just found that the issue is still open. The originator never >>>>>>>>>>> closed >>>>>>>>>>> the damn issue. Can you please close it and somehow get the fixed >>>>>>>>>>> component into the release. >>>>>>>>>>> The ticket number is #348 under 2.6. >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> On 2014-06-27 13:09, Marius Liebenberg wrote: >>>>>>>>>>>> Hi Sebastian >>>>>>>>>>>> I am busy helping someone with a plasma setup and found that >>>>>>>>>>>> the changes >>>>>>>>>>>> that was made prior to the release of 2.6 does not reflect in >>>>>>>>>>>> master. So >>>>>>>>>>>> I would expect that it is not in 2.6 either. >>>>>>>>>>>> I am referring to a change that I made to the THCUD component. >>>>>>>>>>>> Someone >>>>>>>>>>>> else logged the issue but I fixed it and submitted fixed code >>>>>>>>>>>> on the >>>>>>>>>>>> issue tracker. >>>>>>>>>>>> >>>>>>>>>> Hi Marius, I spoke with John Thornton about the thcud velocity >>>>>>>>>> issue. >>>>>>>>>> He'd fixed the problem in thc.comp but not in thcud.comp, but he >>>>>>>>>> fixed >>>>>>>>>> it just now: >>>>>>>>>> >>>>>>>>>> http://git.linuxcnc.org/?p=linuxcnc.git;a=commitdiff;h=2394f70 >>>>>>>>>> >>>>>>>>>> The fix is in 2.6 (v2.6.0-pre4-10-g2394f70) and master >>>>>>>>>> (v2.7.0-pre0-576-g79fd496). >>>>>>>>>> >>>>>>>>>> Does this fix the problem? If so i'll close #348. >>>>>>>>>> >>>>>>>>>> Thanks for reminding me that this was only half fixed.... >>>>>>>>>> >>>>>>>>>> >>>>>>>> ------------------------------------------------------------------------------ >>>>>>>> >>>>>>>> Open source business process management suite built on Java and >>>>>>>> Eclipse >>>>>>>> Turn processes into business applications with Bonita BPM Community >>>>>>>> Edition >>>>>>>> Quickly connect people, data, and systems into organized workflows >>>>>>>> Winner of BOSSIE, CODIE, OW2 and Gartner awards >>>>>>>> http://p.sf.net/sfu/Bonitasoft >>>>>>>> _______________________________________________ >>>>>>>> Emc-developers mailing list >>>>>>>> [email protected] >>>>>>>> https://lists.sourceforge.net/lists/listinfo/emc-developers >>>>>>>> >>>>>> ------------------------------------------------------------------------------ >>>>>> >>>>>> Open source business process management suite built on Java and Eclipse >>>>>> Turn processes into business applications with Bonita BPM Community >>>>>> Edition >>>>>> Quickly connect people, data, and systems into organized workflows >>>>>> Winner of BOSSIE, CODIE, OW2 and Gartner awards >>>>>> http://p.sf.net/sfu/Bonitasoft >>>>>> _______________________________________________ >>>>>> Emc-developers mailing list >>>>>> [email protected] >>>>>> https://lists.sourceforge.net/lists/listinfo/emc-developers >>>>>> >>>>> ------------------------------------------------------------------------------ >>>>> Open source business process management suite built on Java and Eclipse >>>>> Turn processes into business applications with Bonita BPM Community >>>>> Edition >>>>> Quickly connect people, data, and systems into organized workflows >>>>> Winner of BOSSIE, CODIE, OW2 and Gartner awards >>>>> http://p.sf.net/sfu/Bonitasoft >>>>> >>>>> >>>>> _______________________________________________ >>>>> Emc-developers mailing list >>>>> [email protected] >>>>> https://lists.sourceforge.net/lists/listinfo/emc-developers >>>> ------------------------------------------------------------------------------ >>>> Open source business process management suite built on Java and Eclipse >>>> Turn processes into business applications with Bonita BPM Community Edition >>>> Quickly connect people, data, and systems into organized workflows >>>> Winner of BOSSIE, CODIE, OW2 and Gartner awards >>>> http://p.sf.net/sfu/Bonitasoft >>>> _______________________________________________ >>>> Emc-developers mailing list >>>> [email protected] >>>> https://lists.sourceforge.net/lists/listinfo/emc-developers >>>> >> ------------------------------------------------------------------------------ >> Open source business process management suite built on Java and Eclipse >> Turn processes into business applications with Bonita BPM Community Edition >> Quickly connect people, data, and systems into organized workflows >> Winner of BOSSIE, CODIE, OW2 and Gartner awards >> http://p.sf.net/sfu/Bonitasoft >> _______________________________________________ >> Emc-developers mailing list >> [email protected] >> https://lists.sourceforge.net/lists/listinfo/emc-developers >> ------------------------------------------------------------------------------ Open source business process management suite built on Java and Eclipse Turn processes into business applications with Bonita BPM Community Edition Quickly connect people, data, and systems into organized workflows Winner of BOSSIE, CODIE, OW2 and Gartner awards http://p.sf.net/sfu/Bonitasoft _______________________________________________ Emc-developers mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/emc-developers
