On Wed, Jul 23, 2014 at 09:29:57AM -0600, Sebastian Kuzminsky wrote:
> f415df4 hostmot2: move watchdog I/O to the read function
>
> Stray rtapi_kfree(status_reg) without matching rtapi_kmalloc()
> in hm2_watchdog_parse_md().
huh, I thought micges & I fixed this. Will fix.
> In hm2_watchdog_process_tram_read(), no need to check for .io_error
> since the llio read was removed.
OK, will fix.
> bf7c06b hostmot2: Introduce queue_{read,write} methods
>
> queue_read() and queue_write() seems almost but not quite identical
> to tram reads and writes. The difference is the queued reads/writes
> are adjustable on a per-batch basis, whereas the tram reads/writes
> must be configured at driver load time. But they're never used in
> that dynamic way, so maybe a stronger (generic) tram implementation
> would be better?
Queue read/write can work on any addresses it wants. In the ethernet
product, this has an overhead of 4 bytes anytime it's not a contiguous
region. But the cost of sending two packets instead of one is much
higher. This is "good enough" to enable ethernet and I assume that's
why micges did it this way rather than truly finishing use of tram.
Do you feel strongly enough about this to keep hm2_eth out until it
actually uses tram?
> Why was struct hm2_lowlevel_io_struct made __packed__?
I don't know. Will revert this part if it doesn't turn up a problem in
testing. It seems more likely that the structs used for holding the
network packet parts would need to be packed.
> hm2_tram_read() has a silly empty check for queue_read(-1) failure.
This can potentially error, we should note the error just like for
regular reads. (and is the same thing going on on the write side?)
With this quantity of changes to make, it looks like I'd better spin a
-v3 and get more review before merge.
Jeff
------------------------------------------------------------------------------
Want fast and easy access to all the code in your enterprise? Index and
search up to 200,000 lines of code with a free copy of Black Duck
Code Sight - the same software that powers the world's largest code
search on Ohloh, the Black Duck Open Hub! Try it now.
http://p.sf.net/sfu/bds
_______________________________________________
Emc-developers mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/emc-developers
