Ok, I think we have cleaned up the indentation. Let me know if anything is amiss… Thanks, -Tom
Added-initialize-option-to-gs2_vfd.c.patch
Description: Binary data
> On Oct 5, 2015, at 11:06 PM, Sebastian Kuzminsky <s...@highlab.com> wrote:
>
> I looked at what I think is the latest version of your patch: 2.7,
> patched with
> 0003-Added-an-initialize-option-to-gs2_vfd.c-so-it-can-be.patch, patched
> with Added-an-initialize-option-to-gs2_vfd.patch.
>
> The logic looks good to me. I like that you clear isInitialized when
> disabling the GS2, so that it will be re-initialized when .enabled comes
> back on.
>
> My only nitpick is that the indentation in the new "while (done==0) {"
> main loop is inconsistent, and that makes it a bit hard to follow. Our
> coding style guide (src/CodingStyle) says to use what's known as the One
> True Brace Style.
>
> That issue aside, I tested your modified driver on my GS2, and it works
> just like before, which is great. I really appreciate you maintaining
> backwards compatibility, that makes life much easier for our users and
> makes the patch set reasonable for the 2.7 stable branch.
>
> I fiddled with .enable and it seemed to do the right thing, though my
> VFD does not lose power when i enter E-stop so i couldnt test that part.
>
> This has my welcome to go into 2.7 (though I'd like the indentation
> cleaned up, as mentioned above).
>
>
> --
> Sebastian Kuzminsky
>
> ------------------------------------------------------------------------------
> _______________________________________________
> Emc-developers mailing list
> Emc-developers@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/emc-developers
------------------------------------------------------------------------------
_______________________________________________ Emc-developers mailing list Emc-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/emc-developers
