I have the tooledit widget working as I like. This is the first time I have wanted to publish my work on the project. What is the appropriate method for me publishing the modified files?
I have been reading the section on contributing to linuxcnc but I am a bit confused at this point. Do I make my modifications in a fork of the linuxcnc project under my username, or do I make the modifications in a branch within the linuxcnc project? I have already forked linuxcnc to my username. I have cloned the fork to my machine. Modified the files on my machine. Built a RIP linuxcnc based on the modified code. Ran the runtest command on the new build with no errors. Tested the functionality and It is working as I was wanting. I believe the next step is to put my modified code to my linuxcnc fork but I am not sure. Please let me know what the next step is. Also I think this modification could be published in the 2.7 branch as well as master. Currently I have been working with a copy of master. Should I publish the files to the 2.7 branch? Thanks, Jim On 12/22/2016 9:02 PM, Jim Craig wrote: > I use gmoccapy on my milling machine. I really like that gui. Thanks > Norbert! > > The one thing that I think is lacking is the way the tool table works. > It is based on the tooledit_widget. It is a real pain to modify the > tool table while in gmoccapy. To edit an entry you must check the line > you want to edit, click on the cell that you want to edit change the > value then you must press enter to accept the value. To edit another > value you have to click on that cell, edit the value and press enter. > Sorry cmorely, not bashing on your widget. I just want to make it better. > > This is not the way I normally edit a table. I use tab and enter and > arrow keys to navigate a table. I have made some tweaks to the > tooledit_widget.py and tooledit_gtk.glade to allow the tab key to > accept the value in the current cell and advance to the next visible > cell on the current row. I have also made all cells editable without > having to have the checkbox in the first column checked. Also the > Return key or the keypad enter key will accept the value in the > current cell and progress to the same cell in the next row of the > table. This makes navigating the table so much easier and faster. > > I can add in the arrow key movements as well. I have not done that yet > but I can sure do it. > > I am trying to get my RIP install working but I am having issues per > my other emails. Once I test it in a sim gmoccapy then I will be ready > to put it on git if you all agree. > > Let me know if you have any questions or comments. > > Thanks, > > Jim > ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot _______________________________________________ Emc-developers mailing list Emc-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/emc-developers
