Hi Jim
This sounds like a great improvement (I haven't actually tried it) The two ways of presenting one's work is forking or git patch. On small stuff I personally prefer patching (I don't use github much so am rusty) - but it doesn't really matter. As this is an upgrade (arguably) rather then a bug fix - it would usually go in master. tooledit in master may be different - I can't remember - if so you may need to adapt your patch for it. After that there is no real official way to guarantee inclusion or audit. Since Norbert and I probably are most familiar with and use this widget we probably are the best people to bug. I will try to test your widget soon. Chris M ________________________________ From: Jim Craig <jimcraig5...@windstream.net> Sent: December 28, 2016 3:00 AM To: EMC developers Subject: Re: [Emc-developers] tooledit_widget modifications I committed the updated code to my fork of the project at https://github.com/LearningLinuxCNC/linuxcnc [https://avatars2.githubusercontent.com/u/19329127?v=3&s=400]<https://github.com/LearningLinuxCNC/linuxcnc> LearningLinuxCNC/linuxcnc<https://github.com/LearningLinuxCNC/linuxcnc> github.com linuxcnc - LinuxCNC controls CNC machines. It can drive milling machines, lathes, 3d printers, laser cutters, plasma cutters, robot arms, hexapods, and more. I put in a pull request to the linuxcnc project. The updated code allows for normal spreadsheet navigation and editing of the table. Tab and right arrow accepts the value in the current cell and moves to the next visible cell to the right. If the current active cell is the last cell on the row then it moves to the first visible cell on the row. Left arrow key works the same except in the left direction. Enter and down arrow accepts the value in the current cell and moves down one row in the same column. If on the last row then it will move to the first row in the table. The up arrow works the same except in the up direction. Let me know if I need to do anything different. Again first timer here so trying to figure out the correct process here. Thanks, Jim On 12/26/2016 5:53 PM, Jim Craig wrote: > I have the tooledit widget working as I like. This is the first time I > have wanted to publish my work on the project. What is the appropriate > method for me publishing the modified files? > > I have been reading the section on contributing to linuxcnc but I am a > bit confused at this point. Do I make my modifications in a fork of > the linuxcnc project under my username, or do I make the modifications > in a branch within the linuxcnc project? > > I have already forked linuxcnc to my username. I have cloned the fork > to my machine. Modified the files on my machine. Built a RIP linuxcnc > based on the modified code. Ran the runtest command on the new build > with no errors. Tested the functionality and It is working as I was > wanting. > > I believe the next step is to put my modified code to my linuxcnc fork > but I am not sure. > > Please let me know what the next step is. > > Also I think this modification could be published in the 2.7 branch as > well as master. Currently I have been working with a copy of master. > Should I publish the files to the 2.7 branch? > > Thanks, > > Jim > > On 12/22/2016 9:02 PM, Jim Craig wrote: >> I use gmoccapy on my milling machine. I really like that gui. Thanks >> Norbert! >> >> The one thing that I think is lacking is the way the tool table >> works. It is based on the tooledit_widget. It is a real pain to >> modify the tool table while in gmoccapy. To edit an entry you must >> check the line you want to edit, click on the cell that you want to >> edit change the value then you must press enter to accept the value. >> To edit another value you have to click on that cell, edit the value >> and press enter. Sorry cmorely, not bashing on your widget. I just >> want to make it better. >> >> This is not the way I normally edit a table. I use tab and enter and >> arrow keys to navigate a table. I have made some tweaks to the >> tooledit_widget.py and tooledit_gtk.glade to allow the tab key to >> accept the value in the current cell and advance to the next visible >> cell on the current row. I have also made all cells editable without >> having to have the checkbox in the first column checked. Also the >> Return key or the keypad enter key will accept the value in the >> current cell and progress to the same cell in the next row of the >> table. This makes navigating the table so much easier and faster. >> >> I can add in the arrow key movements as well. I have not done that >> yet but I can sure do it. >> >> I am trying to get my RIP install working but I am having issues per >> my other emails. Once I test it in a sim gmoccapy then I will be >> ready to put it on git if you all agree. >> >> Let me know if you have any questions or comments. >> >> Thanks, >> >> Jim >> > ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot _______________________________________________ Emc-developers mailing list Emc-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/emc-developers Emc-developers Info Page - SourceForge<https://lists.sourceforge.net/lists/listinfo/emc-developers> lists.sourceforge.net The Enhanced Machine Controller (EMC) is a CNC machine controller that runs on Linux and is available under the terms of the GNU General Public License. ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot _______________________________________________ Emc-developers mailing list Emc-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/emc-developers
