On Thu, Sep 6, 2018 at 9:50 AM Jon Elson <el...@pico-systems.com> wrote:
> So, for the PPMC DIO (the specific analog interface) and for > the Universal Stepper and PWM controller extra digital > outputs, the invert output parameter is like : > ppmc.0.dout.03.invert > > But, due to the typo, the main digital outputs on the USC > and UPC are like : > > ppmc.0.dout.03-invert > > Note the HYPHEN! > > Now, I could update the docs and leave the code as it is. > But, that makes things pretty inconsistent. > Since this has NEVER been noticed until now, I'm guessing > VERY few people have ever used this feature. > But, if I fix the code, then the driver will have different > behavior and syntax depending on the LinuxCNC version. > > So, any suggestions? Call out the difference in syntax > boldly in the docs, or fix the code to be consistent? I'd like to first note that in the stable branch (2.7) you must *not* break existing configs, but in the development branch (master, aka 2.8-pre) you may (if you add a note to that effect to the "upgrading from 2.7 to 2.8" document, `docs/src/getting-started/updating-linuxcnc.txt`). I like Chris Morley's suggestion to use pin name aliases to supply both the old and new names. I suggest that in 2.7 you leave the existing (incorrect) pin names, and add aliases that provide the new (correct) pin names that match the docs. In master, do the opposite: rename the pins to use the new name, add aliases to provide the old names, and add a note to the Updating document telling your users the old names are deprecated, and to update their HAL files to use the new names. Then in 2.9, remove the aliases (and give another warning in the Updating document). -- Sebastian Kuzminsky ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Emc-developers mailing list Emc-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/emc-developers
