On Thursday 06 September 2018 11:48:34 Jon Elson wrote: > OUCH, I just found a typo in the hal_ppmc.c driver, most > likely it has been there since John Kasunich wrote it in > 2005. Now, I have to decide how to fix it. > > So, for the PPMC DIO (the specific analog interface) and for > the Universal Stepper and PWM controller extra digital > outputs, the invert output parameter is like : > ppmc.0.dout.03.invert > > But, due to the typo, the main digital outputs on the USC > and UPC are like : > > ppmc.0.dout.03-invert > > Note the HYPHEN! > Yeah, but to hal its still a different pin, the inverted version of ppmc.0.dout.03 which I would interpret, according to the mesa syntax everything I have that uses a mesa card would confuse me because the operative description, would be a digital output for the fourth channel.
I am assuming that this particular has analog outputs too, in which case it would be aout.03-invert for that particular inverted pin. I don't see a lot of use for the inverted version of an analog signal. So IMO, the hyphen s/b a legal pin description. But I'm not using any ppmc cards, pmdx yes, but no ppmc in any of my systems. What you do is up to you Jon, I'm just pointing out that ppmc syntax seems to be at odds with mesa syntax. This (to me anyway) would rather simplify the hal checker if the driver(s, there may be more) was fixed to accept the same syntax. > Now, I could update the docs and leave the code as it is. > But, that makes things pretty inconsistent. > Since this has NEVER been noticed until now, I'm guessing > VERY few people have ever used this feature. > But, if I fix the code, then the driver will have different > behavior and syntax depending on the LinuxCNC version. Call it a thinko fix, and tell everyone how to fix it seems like the best way forward. But thats your call, not mine. :) > So, any suggestions? Call out the difference in syntax > boldly in the docs, or fix the code to be consistent? > > Jon > > ---------------------------------------------------------------------- >-------- Check out the vibrant tech community on one of the world's > most engaging tech sites, Slashdot.org! http://sdm.link/slashdot > _______________________________________________ > Emc-developers mailing list > Emc-developers@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/emc-developers -- Cheers, Gene Heskett -- "There are four boxes to be used in defense of liberty: soap, ballot, jury, and ammo. Please use in that order." -Ed Howdershelt (Author) Genes Web page <http://geneslinuxbox.net:6309/gene> ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Emc-developers mailing list Emc-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/emc-developers
