Hello Rene Did u run all the tests successfully in your rebase? I put some changes on top of your work, to totally distinguish between tool table index and pocket.
Regards Daniel Rene Hopf via Emc-developers <emc-developers@lists.sourceforge.net> schrieb am Di. 7. Apr. 2020 um 16:14: > Hi, > There are a few things I would like to change in 2.8. > > 1. > Fix pocket numbers > I rebased my pocket number fix to 2.8, and it seems to work ok. > https://github.com/LinuxCNC/linuxcnc/tree/2.8-pocket-fix < > https://github.com/LinuxCNC/linuxcnc/tree/2.8-pocket-fix> > The branch based on 2.6 has been tested and is used by many people. > If you don’t use a tool changer or the tool table, this does not affect > you. > > 2. > Reload tool on startup. > Currently only random tool changers reload the old tool on startup. > I think this is a bug, and dangerous. > It was requested by so many people to change it, that Norbert even > implemented it in gmoccapy, imho it does not belong in the gui. > If you don’t use a tool changer or the tool table, this does not affect > you. > > 3. > Retain G43 > Almost anybody that has ever used any other controller, has crashed a tool > with linuxcnc due to this behaviour. > Many people complain about it, and there is even a note in the code that > considers it a bug. > > https://github.com/LinuxCNC/linuxcnc/blob/master/src/emc/rs274ngc/interp_convert.cc#L3124-L3134 > < > https://github.com/LinuxCNC/linuxcnc/blob/master/src/emc/rs274ngc/interp_convert.cc#L3124-L3134 > > > 2.8 requires config changes anyway, so its a good time to change it. > If you don’t use a tool changer or the tool table, this does not affect > you. > > If there are no objections, I will implement all those things. > Where do I need to document the changes, so they show up in the release > notes? > > Rene > _______________________________________________ > Emc-developers mailing list > Emc-developers@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/emc-developers > _______________________________________________ Emc-developers mailing list Emc-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/emc-developers
