Itamar Heim has posted comments on this change. Change subject: engine : Hotplug feature - error messages ......................................................................
Patch Set 2: (3 inline comments) see comments in line. also - why are we fixing all these files and committing them rather than generate them during build (unless they are different (which iirc is relevant to admin vs. user portal) - but still seems we have at least one unneeded copy being maintained? .................................................... File backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties Line 613: HOT_PLUG_DISK_IS_NOT_SUPPORTED=Hot plug/unplug is not supported for that cluster version. text: hot plug/unplug of disks is not supported for cluster version X. though this doesn't tell the user what to do (upgrade to version Y to benefit from it) .................................................... File backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties Line 311: FailedToPlugDisk=Failed to hot-plug disk reason? error code? what to do? Line 312: FailedToUnPlugDisk=Failed to hot-unplug disk reason? error code? -- To view, visit http://gerrit.ovirt.org/1016 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7423d2fc2ea8815625e4f80c24c7d7f627d965a9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Itamar Heim <[email protected]> Gerrit-Reviewer: Jonathan Choate <[email protected]> Gerrit-Reviewer: Michael Kublin <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
