Omer Frenkel has posted comments on this change. Change subject: engine : Hotplug feature - error messages ......................................................................
Patch Set 5: (3 inline comments) .................................................... File backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties Line 204: VAR__TYPE__DISK=$type disk to VM i think its better be called VAR__TYPE__DISK_TO_VM so in case some one will want to use it, he will know what he get. any way i think that VAR__TYPE__VM_DISK (line 197 in this file) can work as well: "cannot hot plug virtual machine disk, bla bla.." "cannot hot unplug virtual machine disk, bla bla.." sounds ok to me.. Line 619: HOT_PLUG_DISK_IS_NOT_UNPLUGGED=Disk is already plugged. are you sure the message fit the error? the error say "disk_is_not_unplugged" but the message say "disk is already unplugged" sounds problematic Line 621: HOT_UNPLUG_DISK_IS_NOT_PLUGGED=Disk is already unplugged. same here -- To view, visit http://gerrit.ovirt.org/1016 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7423d2fc2ea8815625e4f80c24c7d7f627d965a9 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Jonathan Choate <[email protected]> Gerrit-Reviewer: Michael Kublin <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
