Omer Frenkel has posted comments on this change.

Change subject: Engine : Hotplug feature - error messages
......................................................................


Patch Set 2: (2 inline comments)

....................................................
File 
backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
Line 76: USER_FAILED_UPDATE_VM_DISK=Failed to update VM ${VmName} Disk (User: 
${UserName}).
the new messages are the same as the regular update disk messages, so maybe not 
needed? or maybe if hot plug/unplug was done so add this info to the message

....................................................
File 
backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties
Line 310: NO_IMPLEMENTATION=Not implemented
the new errors should be added to VdcBllErrors.java

--
To view, visit http://gerrit.ovirt.org/1632
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I45cf2c1cbce3ecbd67ac4ce12fffd53a4900c2ca
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to